style: sort imports #182
Merged
style: sort imports #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck
commented
Feb 27, 2022
| @@ -0,0 +1,17 @@ | |||
| [settings] | |||
There was a problem hiding this comment.
these settings are opinionated,
feel free to change them, @madpah
Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck
force-pushed
the
sort-imports
branch
from
b86334c to
4780a84
Compare
madpah
reviewed
Mar 8, 2022
There was a problem hiding this comment.
@jkowalleck always love some QA stuff :-)
What about a pre-commit hook to allow this to be easier adopted by developers?
|
pre-commit hooks are nice addition, that developers need to enable per project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #85
isortflake8-isortisortto all code, so imports are sorted