Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STYLE] Sort imports #85

Closed
jkowalleck opened this issue Dec 4, 2021 · 0 comments · Fixed by #182
Closed

[STYLE] Sort imports #85

jkowalleck opened this issue Dec 4, 2021 · 0 comments · Fixed by #182
Assignees
Labels
QA Quality Assurance

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Dec 4, 2021

as a developer i want all imports sorted, so i read and maintain them easily


proposal:

  • have isort as a tool available in poetry-dev-env
  • have isort configured -- see below
  • have flake8 plugin flake8-isort` installed and setup in poetry-dev-env
  • have isort applied to all python files (once)
  • have the use of isort mentioned i the CONTRIBUTING docs

proposed isort config file .isort.cfg:

[isort]
## read the docs: https://github.com/timothycrosley/isort/wiki/isort-Settings
known_first_party = cyclonedx
skip_glob =
    build,dist,__pycache__,.eggs,*_cache
    .git,.tox,.venv,venv
    _OLD,_TEST,
    docs
combine_as_imports = true
default_section = THIRDPARTY
include_trailing_comma = true
line_length = 120
multi_line_output = 5
@jkowalleck jkowalleck added the QA Quality Assurance label Dec 4, 2021
@jkowalleck jkowalleck changed the title sort imports Sort imports Dec 5, 2021
@jkowalleck jkowalleck self-assigned this Feb 27, 2022
@jkowalleck jkowalleck changed the title Sort imports [STYLE] Sort imports Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Quality Assurance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant