Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name option in a separate file #98

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

RadWolfie
Copy link
Member

Instead of add name option in config.txt file, I decided to use it in name.txt file for the following reasons:

  1. Ability not need to re-edit config.txt file for each machine every time. This way, config file can be edit once and send to all machines to run the tests to get results back for the reason below.
  2. Ability to name kernel_tests.log to a custom suffix name log. i.e. without name.txt file would be kernel_tests.log by default. With name.txt file will use kernel_tests-<name>.log. This allow for testers to download from all machines into same folder than download individual log files renamed to what machine was used.
  3. Profit??

In name.txt file:
<name (first line only)>

@RadWolfie RadWolfie mentioned this pull request Feb 19, 2024
7 tasks
src/main.c Outdated Show resolved Hide resolved
src/main.c Show resolved Hide resolved
src/main.c Show resolved Hide resolved
src/main.c Show resolved Hide resolved
src/main.c Show resolved Hide resolved
src/main.c Show resolved Hide resolved
src/main.c Show resolved Hide resolved
Copy link
Member

@PatrickvL PatrickvL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks

@RadWolfie RadWolfie merged commit 5ea96a8 into Cxbx-Reloaded:master Feb 25, 2024
1 check passed
@RadWolfie RadWolfie deleted the add-name-option branch February 25, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants