-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name option in a separate file #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ergo720
reviewed
Feb 22, 2024
RadWolfie
force-pushed
the
add-name-option
branch
from
February 22, 2024 20:23
37dbcb8
to
b3d825e
Compare
PatrickvL
reviewed
Feb 23, 2024
PatrickvL
reviewed
Feb 23, 2024
PatrickvL
reviewed
Feb 23, 2024
PatrickvL
reviewed
Feb 23, 2024
PatrickvL
reviewed
Feb 23, 2024
PatrickvL
reviewed
Feb 23, 2024
PatrickvL
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of add name option in config.txt file, I decided to use it in name.txt file for the following reasons:
kernel_tests.log
by default. With name.txt file will usekernel_tests-<name>.log
. This allow for testers to download from all machines into same folder than download individual log files renamed to what machine was used.In
name.txt
file:<name (first line only)>