Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Log Info Support #95

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Additional Log Info Support #95

merged 3 commits into from
Feb 8, 2024

Conversation

RadWolfie
Copy link
Member

@RadWolfie RadWolfie commented Feb 4, 2024 •
edited
Loading

What's already upstreamed:

  • build hash

From this pull request:

  • Submitter
  • bios/kernel version
  • Xbox hardware info flag (helpful to see detail of what kernel sets to)
  • PIC version (including console type prediction)
  • Xbox hardware revision:
    • GPU (PCI)
    • MCPX (PCI)

Undecided:

What will not be included:

  • Run timestamp
  • Used emulator + version / build hash + relevant settings

For any missing details, such as hardware revision, please discuss in #6 ticket. Thanks!

PatrickvL
PatrickvL approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@PatrickvL PatrickvL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ergo720
ergo720 reviewed Feb 7, 2024
View reviewed changes
src/main.c Outdated Show resolved Hide resolved
ergo720
ergo720 reviewed Feb 7, 2024
View reviewed changes
src/util/hardware.h Outdated Show resolved Hide resolved
@RadWolfie RadWolfie force-pushed the additional-log-info branch from 5c5af9d to 5405dc3 Compare February 7, 2024 21:45
@ergo720 ergo720 merged commit 4c60b2b into Cxbx-Reloaded:master Feb 8, 2024
1 check passed
@RadWolfie RadWolfie deleted the additional-log-info branch February 8, 2024 12:08
@RadWolfie RadWolfie mentioned this pull request Feb 11, 2024
Merged
@RadWolfie RadWolfie mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ergo720 ergo720 ergo720 left review comments

@PatrickvL PatrickvL PatrickvL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RadWolfie @PatrickvL @ergo720