Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG_SP] Combine Header Stops Gathering Fruit Just Before Combine Stops #2592

Closed
lcc1211 opened this issue Jun 18, 2023 · 26 comments · Fixed by #2822
Closed

[BUG_SP] Combine Header Stops Gathering Fruit Just Before Combine Stops #2592

lcc1211 opened this issue Jun 18, 2023 · 26 comments · Fixed by #2822
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lcc1211
Copy link

lcc1211 commented Jun 18, 2023

READ FIRST
https://github.com/Courseplay/Courseplay_FS22/wiki

Steps to reproduce
Harvest any field on Iowa Plains

Actual behavior
When the combine stops while harvesting and the tipper is called to offload, the combine's header stops but the combine is still in motion leaving strips of unharvested fruit all over the field. It does happen on smaller fields, but happens a lot on larger fields.

Expected behavior
The headers should continue moving until the combine stops, or ideally, just after the combine stops.

Screenshots
Example
Example2

Courseplay version
7.2.1.4

Log

log.txt

Map
Iowa Pla

Vehicles/ implements involved
Which vehicle or implement? Claas Lexion 8900 with 1380 Combio Header
Mod yes/no ? Yes, but same results with vanilla equipment.

Relevant script mods
N/A

@lcc1211 lcc1211 added the bug Something isn't working label Jun 18, 2023
@Tensuko
Copy link
Contributor

Tensuko commented Jun 19, 2023

Never had this happen.
Your BetterContracts throws a Callstack, not sure if this will cause some game stuttering, but I don't have anotehr explanation.
Also we implemented a slow down for the last %.

Try out complete Vanilla and see if it still happens.

@Tensuko Tensuko added waiting for user User answer needed can't reproduce reproduction impossible labels Jun 19, 2023
@lcc1211
Copy link
Author

lcc1211 commented Jun 19, 2023

I will remove the BetterContracts and see if that changes the behavior.

@lcc1211
Copy link
Author

lcc1211 commented Jun 20, 2023

I completely uninstalled the BetterContracts mod, but CP still stops the spinning of the header about a meter before the combine stops. To maybe make this a bit more easy to understand: The problem isn't happening when the combine is full and stops. It seems to happen when the combine stops to wait for the tipper to arrive.

@Tensuko
Copy link
Contributor

Tensuko commented Jun 21, 2023

Did you test complete Vanilla as I said?

@Symbob
Copy link

Symbob commented Jun 21, 2023

I also find this happens, but mainly on fields with slopes. If the combine is facing downhill it will leave these unharvested strips. It doesn't do it when facing uphill. I could be wrong, but I've always assumed it was because the combine creeps forward slightly when stopped to unload facing downhill. When it starts harvesting again it has crept passed a small amount of crop. The steeper the slope the more crop gets missed. Perhaps a work around would be to have the combine reverse backwards a few metres after unloading, and before it starts harvesting again?

I'm also using the same harvester and header, but I've seen this happen with other harvesters too.

@Tensuko
Copy link
Contributor

Tensuko commented Jun 22, 2023

No driving backwards.
I will see when and why this happens and may adjust the slow down.

@Tensuko Tensuko added under investigation trying to figure out whats happening and removed waiting for user User answer needed can't reproduce reproduction impossible labels Jun 22, 2023
@dkfiremann
Copy link

What is your values for tool settings for raising and lowering ?

@Tensuko
Copy link
Contributor

Tensuko commented Jun 23, 2023

There are no values for raising and lowering the header at this point.

The Settings you mean are only for turns.

@Tensuko
Copy link
Contributor

Tensuko commented Jun 30, 2023

22Ha Field with Tucano and 7.8m work width.
Never had the situation and my combine had to stop many times (map is big and only one unloader).
Field is also not flat at all.
grafik

@Tensuko Tensuko added can't reproduce reproduction impossible and removed under investigation trying to figure out whats happening labels Jun 30, 2023
@Tensuko
Copy link
Contributor

Tensuko commented Aug 22, 2023

Still not able to reproduce this.
No Idea whats going on on your side.
When you can record a video of this happening with a complete logfile with debug turned on, then reopen this Issue pls so we can have a closer look.
Might be some edge case.

@Tensuko Tensuko closed this as completed Aug 22, 2023
@nitroSkirata
Copy link

Hey, I have the same problem, just investigated it some more:

It seems to me, that the combine drives on, before the header is spun up and lowered. this can be solved by waiting a seconds between starting the combine and header and driving forward.

Equiptment used:
Claas 8900 https://www.farming-simulator.com/mod.php?lang=en&country=gb&mod_id=228187&title=fs2022
John deere HD50 header https://www.farming-simulator.com/mod.php?lang=en&country=gb&mod_id=267222&title=fs2022

log.txt
https://youtu.be/rP04z92faxQ

@Tensuko
Copy link
Contributor

Tensuko commented Aug 26, 2023

Must be a mod issue / mod conflict.
Look at whats happening, he starts driving while lowering the tool.
I don't have that happening.

@Symbob
Copy link

Symbob commented Aug 27, 2023

@Tensuko Could it be an issue with the Claas Lexion 8900? The only common factor between all of us that are having the problem is that we are using the same harvester. In your test you used a different harvester. I've been too busy at work over the past few months to play FS but as soon as I get a chance I'll do a bit more testing.

@lcc1211
Copy link
Author

lcc1211 commented Aug 27, 2023

@Symbob @Tensuko I've had the issue with other mods. For instance, yesterday I was using John Deere HD45X 13.7 meter header with the John Deere S670 (2015) combine and it happened with it as well. I think it happened with a Rostelmash and the 9 meter header as well. I'll try getting a video/log & debug today with that same setup.

@lcc1211
Copy link
Author

lcc1211 commented Aug 27, 2023

Using John Deere HD45X 13.7 meter header with the John Deere S670 (2015) at about the 31 minute mark.
log.txt
I couldn't get the video because the recording was corrupted, but here is a screenshot.
LeftBehind

@Tensuko
Copy link
Contributor

Tensuko commented Aug 27, 2023

I need a video to see whats happening...
As I said in that one video the combine starts driving while still lowering.
I have this never happened to me.

@lcc1211
Copy link
Author

lcc1211 commented Aug 28, 2023

So it seems the majority of the time this happens is when the co
log.txt
mbine nears the end of a row and CP calls the tipper. Go to the 7 minute mark of the video. https://youtu.be/2UTdEUQgWjU

@Tensuko
Copy link
Contributor

Tensuko commented Aug 29, 2023

Still weird.
Why he wouldn't keep collect fruit when the harvester is still on and the header down?

@lcc1211
Copy link
Author

lcc1211 commented Aug 29, 2023

Still weird. Why he wouldn't keep collect fruit when the harvester is still on and the header down?

There is a short time where the header stops spinning. Check it at the roughly 7:20 to 7:30 mark. It is a couple of seconds long.

@lcc1211
Copy link
Author

lcc1211 commented Sep 2, 2023

It also happens when using the potato harvester. The most common denominator seems to be that when the harvester nears the end of the field and calls the vehicle offloading, a portion of the fruit can be missed. Could CP just not stop the header? Could that be a solution?
PotatoLeftBehind

@Tensuko
Copy link
Contributor

Tensuko commented Sep 19, 2023

Found this happening now for the very first time.
Thats very strange and hard to catch.
Reopen, but can't say when this will be solved.

@Tensuko Tensuko reopened this Sep 19, 2023
@Tensuko Tensuko removed the can't reproduce reproduction impossible label Sep 19, 2023
@lcc1211
Copy link
Author

lcc1211 commented Sep 24, 2023

I've been watching when this happens. Nearly (but not quite) 100% of the time it happens when the combine is nearing the end of a row and calls the tipper. usually the fill level isn't all that high. I've seen it as low as 35%. If you intentionally adding this as a function, perhaps the fix is to just remove that option.

@Tensuko
Copy link
Contributor

Tensuko commented Sep 30, 2023

I now had this happening in a blocked situation:
grafik

Maybe together with fuel save? Not sure...

@lcc1211
Copy link
Author

lcc1211 commented Sep 30, 2023

Turning fuel save off? Maybe. I'll give it a try.

@pvaiko pvaiko self-assigned this Sep 30, 2023
pvaiko added a commit that referenced this issue Sep 30, 2023
Wait for stopping when waiting for unload at end of row.

Delayed header turn off by 2 seconds in all cases, just
to make sure.

#2592
@pvaiko pvaiko linked a pull request Sep 30, 2023 that will close this issue
@Tensuko
Copy link
Contributor

Tensuko commented Sep 30, 2023

@lcc1211 if you know how to grab a Branch, you can try out this one:
#2822

@lcc1211
Copy link
Author

lcc1211 commented Sep 30, 2023

@Tensuko I'm afraid that is not something I know how to do.

@Tensuko Tensuko added this to the 7.3.1.3 milestone Oct 1, 2023
Tensuko added a commit that referenced this issue Oct 18, 2023
- Changed description for combine unload on 1st headland to be more clear, also set the default setting to false.
- fix for #2592
- fix for reversing turn.
- Pipe won't open for a CP combine unloader that is in idle state.
- Removed Giants collision that prevented our unloader to react to our combine.
- fix for #2812
- fix for #2801
- fuel info now is shown when AI driver is stopped because of low fuel for all setting states by @tn4799
- fix for the info messages not always clearing correctly on MP
- Adjusted silo end detection with shovel loading. #2783
- Added columns to silo map, for selection of the optimal silo part to load.
- Fixes bug for bunker silo driver, where driving to park position failed. #2783
- Added leveler height offset to the ground setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants