Removed NavigationBar margin for iOS 11 #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intoxicated
commented
Feb 25, 2018
| self.init(frame: .zero) | ||
| } | ||
| var l: CGFloat = 0 | ||
| var r: CGFloat = 0 |
There was a problem hiding this comment.
by the way, I see a lot of variable name like l, r, c which made me confused for a minute. I think it would be better to elaborate variable name more concisely
There was a problem hiding this comment.
Excellent comment. I will update these. Thank you!
|
Awesome, I will test this and add it to the next release. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #995 by adding
for iOS 11 navigationBar margin and fixed indentation. Let me know your opinion! @DanielDahan