Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Left & Right Views position #995

Closed
Shempaiii opened this issue Dec 11, 2017 · 10 comments · Fixed by #1038
Closed

Navigation Left & Right Views position #995

Shempaiii opened this issue Dec 11, 2017 · 10 comments · Fixed by #1038

Comments

@Shempaiii
Copy link

Why they have great amount of space?

Image attached below.

screen shot 2017-12-11 at 2 48 38 pm

@daniel-jonathan
Copy link
Member

This is an iOS 11 issue. iOS 11 adds some spacing. This issue has been noted internally and will be potentially fixed in Material 3, if a work around has not been added before hand. I will leave this up as a reminder. Thank you!

@intoxicated
Copy link
Contributor

@DanielDahan would you mind if I can fix this with work around and PR? it seems like its related to UIStackView with iOS 11 that they added up some constraint it internally.

@daniel-jonathan
Copy link
Member

@intoxicated I would appreciate your help very much. Let me know what I can do to help you fix this. Thank you!

@intoxicated
Copy link
Contributor

@DanielDahan i'll set up project and play around with it for a couple day :) ill let you know

@daniel-jonathan
Copy link
Member

@intoxicated excellent, thank you! From Friday to Tuesday I will not be around, so please, if you need me, ping me before or after that time.

@intoxicated
Copy link
Contributor

@DanielDahan sorry I was quite busy last couple weeks! Now I'm investigating NavigationBar, NavigationItem part.

  1. Am I on right track?
  2. It seems like indentation for code base somewhat mixup with 4 and 2. And as far as I know, indentation 2 is preferable for swift.
  3. Material.Toolbar seems like having inset (left/right).

screen shot 2018-02-25 at 6 30 20 pm

@intoxicated
Copy link
Contributor

Fixed on #1038 and I confirmed with running sample NavigationController. Any feedbacks would be appreciated!

@OrkhanAlikhanov
Copy link
Contributor

@DanielDahan Can we close this? Because #1038 is merged and is said to solve this issue.

It would be better to get feedback from @shemchavez though.

@Shempaiii
Copy link
Author

Hey, would check this tomorrow. Thanks by the way for fixing it.

@daniel-jonathan
Copy link
Member

Yes this is fine to close. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants