Ibc fixes #174
Merged
Ibc fixes #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| has_ibc_entry_points: report.has_ibc_entry_points, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice implementation. I'm glad we don't need to worry about C layout in cosmwasm_vm.
There was a problem hiding this comment.
Yeah, I'd only do with that right at the FFI boundary.
Normal rust types in cosmwasm-vm and normal go types in wasmd.
This type just is used inside this same repo on both sides of FFI
This repo does not have one. It is wild west style here. |
|
Ready to merge from my side. @alpe if you approve, I will remove the |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #172
Includes all updates from CosmWasm/cosmwasm#728 and CosmWasm/cosmwasm#736
This should be the "final" (for next release) state of ibc support in the cosmwasm vm and contracts
TODO: