Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBC Enhancements #728

Merged
merged 11 commits into from
Jan 20, 2021
Merged

IBC Enhancements #728

merged 11 commits into from
Jan 20, 2021

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Jan 18, 2021 •
edited
Loading

Closes #692
Follow-up from #714

Adds the last missing details for this github issue

  • Add some comments on timeout_timestamp format
  • Add CHANGELOG entry
  • Add ibc tests to vm
  • Rename "Rename IbcTimeoutHeight.TimeoutHeight" -> "TimeoutBlock.Height"
    - [x] Add port_id to IbcMsg::Transfer (to match SDK `MsgTransfer)
  • Add functionality to ChannelClose in ibc-reflect. Delete local channel/reflect address, but first "steal" all native tokens from reflect contract to the factory
  • Add attributes to all ibc callbacks in ibc-reflect to allow proper integration testing

@ethanfrey ethanfrey mentioned this pull request Jan 18, 2021
Closed
7 tasks
@webmaster128
Copy link
Member

It would be good to include unit tests of ibc_calls::{call_ibc_channel_close, call_ibc_channel_connect, call_ibc_channel_open, call_ibc_packet_ack, call_ibc_packet_receive, call_ibc_packet_timeout}; in packages/vm/src/ibc_calls.rs the same was as shown in packages/vm/src/calls.rs. This requires adding an IBC contract to the VM's testdata directory.

Base automatically changed from master to main January 19, 2021 22:43
@ethanfrey ethanfrey marked this pull request as ready for review January 20, 2021 13:35
@ethanfrey
Copy link
Member Author

@webmaster128 This should be complete and is ready for review. When merged, I will make the corresponding updates in wasmvm

webmaster128
webmaster128 reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests. Just two small remarks, the 🚀

contracts/ibc-reflect/src/contract.rs Outdated
let mut deps = setup();

let channel_id: &str = "channel-123";
let account: &str = "acct-123";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: explicit type should only be needed for consts. Here it can be derived.

packages/vm/src/ibc_calls.rs Outdated
call_init::<_, _, _, Empty>(&mut instance, &mock_env(), &info, msg)
.unwrap()
.unwrap();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this place we are not testing the contract but the calls and call_init is tested in the other file. So I think this test should be remioved.

@webmaster128 webmaster128 added the automerge See mergify.io label Jan 20, 2021
@mergify mergify bot merged commit e606c75 into main Jan 20, 2021
@mergify mergify bot deleted the ibc-enhancements branch January 20, 2021 15:29
@ethanfrey
Copy link
Member Author

Thanks for the fixes

@ethanfrey ethanfrey mentioned this pull request Jan 20, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
automerge See mergify.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add optional ibc entry point
2 participants
@ethanfrey @webmaster128