Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up query output. #49

Closed
4 tasks
ethanfrey opened this issue Jan 23, 2020 · 0 comments · Fixed by #50
Closed
4 tasks

Clean up query output. #49

ethanfrey opened this issue Jan 23, 2020 · 0 comments · Fixed by #50
Assignees

Comments

@ethanfrey
Copy link
Member

Summary

The mapping from cosmwasm data to the query output is not so clean. We often use string to represent data we know is either (1) binary or (2) json. Let us use []byte/tmbytes.HexBytes for the binary data and json.RawMessage for the json.

Problem Definition

wasmcli query wasm output is often hard to read

Proposal

  1. ContractInfo should have json.RawMessage ([]byte alias) for InitMsg
  2. types.Model used by QueryMethodContractStateAll and QueryMethodContractStateRaw should not be {string, string}, but {HexBytes, json.RawMessage}

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ethanfrey ethanfrey self-assigned this Jan 23, 2020
@ethanfrey ethanfrey mentioned this issue Jan 23, 2020
9 tasks
loloicci pushed a commit to loloicci/wasmd that referenced this issue Jun 14, 2023
loloicci added a commit to loloicci/wasmd that referenced this issue Aug 19, 2024
…CosmWasm#53)

* build: replace line repositories with finschia repositories (CosmWasm#30)

* build: replace line repositories with finschia repositories

* Update x/wasmplus/README.md

Co-authored-by: zemyblue <[email protected]>

* Update x/wasm/ibc_reflect_test.go

Co-authored-by: zemyblue <[email protected]>

* Update .github/dependabot.yml

Co-authored-by: jaeseung-bae <[email protected]>

* Update CHANGELOG.md

Co-authored-by: jaeseung-bae <[email protected]>

* Update CHANGELOG.md

Co-authored-by: jaeseung-bae <[email protected]>

* docs: replace a comment contains line with finschia one

* build: replace line in Dockerfile with finschia

* docs: replace line in README.md with Finschia

* docs: update CHANGELOG

---------

Co-authored-by: zemyblue <[email protected]>
Co-authored-by: jaeseung-bae <[email protected]>

* chore: update changelog for release v0.1.3 (CosmWasm#31)

* fix: stop wrap twice the response of handling non-plus wasm message in plus handler (CosmWasm#35)

* fix: stop wrap twice non-plus wasm hander's response

fix Finschia#33

* test: add tests handling non-plus wasm messages

* docs: add this PR to CHANGELOG.md

* fix: reflect golangci-lint

* fix: simplify how to handle the message in wasmplus

* chore: update notice (CosmWasm#44)

* chore: update notice

* chore: update changelog

* fix: delete unnecessary test (CosmWasm#43)

* fix: delete unnecessary test

* docs: add CHANGELOG

* feat: add admin-related events (CosmWasm#46)

* add admin-related events in docs
* fix ClearAdmin event
* cherry-pick upstream admin-related events update

* chore: update changelog for release v0.1.4 (CosmWasm#49)

* build: update depending wasmvm to v1.1.1-0.11.2-dynamiclink2 and update tests

---------

Co-authored-by: zemyblue <[email protected]>
Co-authored-by: jaeseung-bae <[email protected]>
Co-authored-by: Daisuke Iuchi <[email protected]>
Co-authored-by: Jayden Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant