Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup query api #50

Merged
merged 4 commits into from
Jan 24, 2020
Merged

Cleanup query api #50

merged 4 commits into from
Jan 24, 2020

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Jan 23, 2020

Closes #49

  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   63.39%   63.39%           
=======================================
  Files          14       14           
  Lines        1101     1101           
=======================================
  Hits          698      698           
  Misses        337      337           
  Partials       66       66
Impacted Files Coverage Δ
x/wasm/internal/keeper/genesis.go 0% <0%> (ø) ⬆️
x/wasm/internal/keeper/keeper.go 67.46% <100%> (ø) ⬆️
x/wasm/internal/keeper/querier.go 26.13% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24dcc9...a8fd5e9. Read the comment docs.

@ethanfrey ethanfrey marked this pull request as ready for review January 24, 2020 10:31
@ethanfrey ethanfrey merged commit eab4c94 into master Jan 24, 2020
@ethanfrey ethanfrey deleted the cleanup-query-api branch January 24, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up query output.
2 participants