Skip to content

Commit

Permalink
Merge pull request godotengine#98431 from lodicolo/4.3-stable_GH_76825
Browse files Browse the repository at this point in the history
Fix GodotFetch glue code for null response bodies
  • Loading branch information
Repiteo committed Oct 24, 2024
2 parents db60dcc + c7f421e commit 1015a48
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions platform/web/js/libs/library_godot_fetch.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,12 @@ const GodotFetch = {
});
obj.status = response.status;
obj.response = response;
obj.reader = response.body.getReader();
// `body` can be null per spec (for example, in cases where the request method is HEAD).
// As of the time of writing, Chromium (127.0.6533.72) does not follow the spec but Firefox (131.0.3) does.
// See godotengine/godot#76825 for more information.
// See Chromium revert (of the change to follow the spec):
// https://chromium.googlesource.com/chromium/src/+/135354b7bdb554cd03c913af7c90aceead03c4d4
obj.reader = response.body?.getReader();
obj.chunked = chunked;
},

Expand Down Expand Up @@ -121,6 +126,10 @@ const GodotFetch = {
}
obj.reading = true;
obj.reader.read().then(GodotFetch.onread.bind(null, id)).catch(GodotFetch.onerror.bind(null, id));
} else if (obj.reader == null && obj.response.body == null) {
// Emulate a stream closure to maintain the request lifecycle.
obj.reading = true;
GodotFetch.onread(id, { value: undefined, done: true });
}
},
},
Expand Down Expand Up @@ -159,7 +168,10 @@ const GodotFetch = {
if (!obj.response) {
return 0;
}
if (obj.reader) {
// If the reader is nullish, but there is no body, and the request is not marked as done,
// the same status should be returned as though the request is currently being read
// so that the proper lifecycle closure can be handled in `read()`.
if (obj.reader || (obj.response.body == null && !obj.done)) {
return 1;
}
if (obj.done) {
Expand Down

0 comments on commit 1015a48

Please sign in to comment.