Fix GodotFetch glue code for null response bodies #98431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
requested changes
Oct 22, 2024
lodicolo
force-pushed
the
4.3-stable_GH_76825
branch
from
a7f2dc8 to
a36871f
Compare
|
You can remove me from the commit! Keep ownership of it, really. |
The spec says that Response.body can be null (in the event of requests that should have no body, like HEAD requests) and Firefox adheres to it which results in request failure for HEAD requests on Firefox for web exports. This commit addresses that by treating a null body as an "empty" body (without using a polyfill) and avoids changing the request lifecycle as much as possible. PR review changes: - Use == instead of strict === - Do not use ?? null - Comment formatting
lodicolo
force-pushed
the
4.3-stable_GH_76825
branch
from
a36871f to
c7f421e
Compare
|
I updated the commit and also fixed the eslint error, and rebuilt the export locally and re-verified it on both my project as well as the MRP I provided. Thanks for the review! |
adamscott
approved these changes
Oct 23, 2024
|
Thanks, and congratulations on your first contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76825
The spec says that
bodycan benullfor fetch responses (in the event of requests that should have no body, like HEAD requests) and Firefox adheres to it which results in request failure for HEAD requests on Firefox for web exports.This fix addresses that by treating a
nullbody as an "empty" body (without using a polyfill) and avoids changing the request lifecycle as much as possible.Minimal reproduction project: mrp-gh76825.zip