-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support for json-like input and outputs in the schema #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit refactors the code by updating the type parameter name from "DoNotCastToPrimitive" to "CastBehavior" in order to improve code clarity and consistency.
Thanks a lot, will check out within a day |
qwelias
reviewed
Oct 29, 2023
qwelias
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks
@qwelias I released a I noticed one regression for undefined values in objects. I think it should make Jsonlike key optional, like: type Obj = {
a: string | null | undefined
}
type ResultJsonLikeType = {
a?: string | null
}
declare const obj: Obj;
// works as JSON.strinigfy(obj) will remove undefined values
req.send(obj) // results in a {} response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #89
request body is typed as json-like structure, while response body is not fully casted and doesn't cast original types from schema.
@qwelias, it was a nice puzzle! Could you please verify if it meets your expectations, works correctly, and covers all your cases? Thank you.