Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonified req.body and reply.send #89

Closed
wants to merge 3 commits into from
Closed

Conversation

qwelias
Copy link
Collaborator

@qwelias qwelias commented Oct 26, 2023

No description provided.

@qwelias
Copy link
Collaborator Author

qwelias commented Oct 26, 2023

hi @Coobaha , would appreciate any feedback on it and another PR

@Coobaha
Copy link
Owner

Coobaha commented Oct 26, 2023

Thank you @qwelias, I appreciate your contribution! 🙌 I will take a look soon

@qwelias qwelias changed the title feat: allow jsonified variants in response jsonified req.body and reply.send Oct 26, 2023
@qwelias
Copy link
Collaborator Author

qwelias commented Oct 26, 2023

Last commit is failing, but I couldn't figure out why.

Seems like body is being jsonified into {} losing user, but I couldn't reproduce this in isolation, as following snippet produces correct foo type for the similar schema structure

interface Foo {
  asd: string
}

type foo = Jsonify<{
  foo: Foo
}>

Can remove it from this PR, if you think it's fine without req.body for now

@Coobaha
Copy link
Owner

Coobaha commented Oct 29, 2023

I was able to get it working in #92, could you please verify? 🙏

@Coobaha Coobaha closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants