Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the calendar tracker feature #9

Merged

Conversation

RITIK-CHAUDHRY
Copy link

@RITIK-CHAUDHRY RITIK-CHAUDHRY commented Oct 23, 2024

Description

Implement the calendar tracker feature

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Motivation and Context

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Screenshots (if appropriate):

Screen_Recording_20241023_164510_Easy.2.Do.mp4

Checklist:

  • I have registered myself at Contrihub website.
  • My code follows the code style of this project.
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • Any dependent changes have been merged and published in downstream modules
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

i have modified Fragment2PriorityTaskRule.java and fragment_2priority_task_rule.xml .
i have added custom_edittext_background.xml to provide a custom background for the input fields in the fragment_2priority_task_rule.xml layout file. also modified the files to eliminate the errors
i tried to mitigate all the issues that you have mentioned but there is one syntax error of closing brackets. i have reviewed code multiple time but won't able to get how to fix it. i believe after fixing that the issue will get resolved. please help me into that
@RITIK-CHAUDHRY
Copy link
Author

@mukul-dev please review my pr

@mukul-dev
Copy link
Collaborator

@mukul-dev please review my pr

image

Seems like some resource is missing ... I think the URI resource is unable to fetch ... Did you encounter similar error? I tried many a solutions from stackoverflow but none worked..! If you solved this error do share the method.. I am trying for it too but not getting how it can be resolved!

@RITIK-CHAUDHRY
Copy link
Author

@mukul-dev sir previously because i have worked on issue #4 my repo also contain that part as that files have bugs so when you are checking that files showing error. to resolve this error you open your repo and change only 3 files that i have changed and make local.properties acc to your sdk location of the system. then attaching device with usb debugging on will showcase the same results as of mine.

@RITIK-CHAUDHRY
Copy link
Author

RITIK-CHAUDHRY commented Oct 23, 2024

@mukul-dev the changes i have done to achieve this is fragment2day.java, 2day.xml in reslayout and in res values styles.xml.......just take these files of mine and then run it'll run..

@mukul-dev
Copy link
Collaborator

Great work @RITIK-CHAUDHRY ! Your code is working close to expected but the main part is still missing the days marked are not yet visible on the calendar.. Implement it as if a day is marked (whether streak is alive or broken) it should bhi visible on the calendar! Additionally, the UI for showing the streak count needs to be pleasing! So you can improve that and keep it just above the calendar!
Make these changes so that the feature requirements as of now can be fulfilled! Also, for merging this if you can remove the changes you've done in other files regarding other issues, it will be easier or else I can just push your changes to the repo and accept your PR then on the portal! Let me know what you choose to do! 👍👍

@RITIK-CHAUDHRY
Copy link
Author

@mukul-dev sir to mark the date we have to integrate the MaterialCalendarView library to achieve the desired functionality of highlighting the selected dates with a dark red circle. sir

i had made all the changes that are advised to me. regarding encircling the date that is marked we have to use third party lib which i mentioned in my comment. I even tried using that library but on doing so the app is not behaving well. android devices cannot percepts that library and showing errors.
@mukul-dev mukul-dev merged commit 57ff998 into ContriHUB:main Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Calendar Tracker Feature
2 participants