fixed issue #4 #8
Conversation
|
@RITIK-CHAUDHRY Quite a few things need to be corrected like:
Do more of testing with different situations and activities within this feature considering yourself using the app, it will make you find bugs easily! |
|
@mukul-dev sir i am working on the improvements that you had mentioned just after your comment. I have submitted the pr link in contrihub. now its showing only 50 min left. so the changes that i done in this will give me points if i will submit the changes mentioned by you after 50min or i have to constraint myself to 50min |
made changes
|
@RITIK-CHAUDHRY No, you can work and fix ... your PR request is still there, and I will provide points and feedback accordingly by tomorrow after reviewing so you can let me know when you are done with fixing them... |
|
@mukul-dev i made changes from my side please have a look on it. |
There are a few errors still in the code when i pulled this version.. can you please share the screenshots of working app (for this fragment only) ... |
|
@mukul-dev sir can you elaborate the errors that you have encountered so that i can fix those and get back to you |
Yes @RITIK-CHAUDHRY , actually some of them are not really that big like just identifier/token name is wrong that I can fix while testing.. Actually, I am sharing the screenshot of IDE after pulling your request where there are errors of missing files and some code errors. IMAGE 1: IMAGE 2: At first I thought there is some issue while pulling but I checked in commits here on GitHub and in your last commit everything is just like this... so there might be something faulty when you committed changes... If the app is working on your IDE with your code you can share that too I will try to check with that... because the implementation seems correct but just these few errors are there.. |
|
@RITIK-CHAUDHRY you can commit changes (if you rectified these errors) by 10 pm today, because there are more people who want to work on this issue. So, I have to assign it to them! |
|
yes sir i am working into the issues right now. it takes time as i am trying that no further issues will be raised. i will try to commit changes as soon as possible. @mukul-dev |
|
@RITIK-CHAUDHRY sure .. try finishing before 10pm so that i can review and accept.. or assign others! |
|
@mukul-dev sir can you help me on this |
|
@RITIK-CHAUDHRY yes you can add this for customising the style.. just assign this to style or background attribute of the input fields in the xml |
|
@mukul-dev sir review it |
|
@RITIK-CHAUDHRY There are still a lot of things that aren't working... and some were working before but not working now... like why you removed the code for SAVE button... now its not saving the tasks.. rest things can not be tested without saving .. The Resetting the input box at 00:00 am is also removed.. and so on... I cannot merge this as of now ... You have to implement and try running on your mobile phone so that you get to know its working as expected or not... As of now I have to assign it to the other guy but if you are still interested in working for this feature you can later submit this.. |
|
sorry to hear that sir.i will generate a commit by EOD to mitigate all problems @mukul-dev |
|
@mukul-dev sir i have rasised PR please review last time. please read the description. |
|
@mukul-dev can you please update me on the last PR |
fixed issue ContriHUB#4 . in this version of the app the user can give input of the tasks and henceforth can mark as done when it is done. a pop up will come which ensure that use confirm the marking. task2 can be marked as done only if task 1 is completed
|
@mukul-dev sir i have modified my PR also i have done all the changes that are previously mentioned. sorry for the inconvinience caused due to delays. |
|
@mukul-dev sir please review this PR too and if its okay please merge it |
|
@RITIK-CHAUDHRY the text being dispayed in the text box doesnt match the state actually... below are some screenshots for you reference.. also user is allowed to complete any task first (not just the first one, like implemented now)... I think these are easier to fix.. so you can submit the corrected version and we can finish this!! Great work! |
|
@mukul-dev pardon sir for this.. is there anything that i can do extra for bonus that you like to suggest |
nothing much as of now... just rectify these bugs.. you may try to improve the UI .. probably with the use of some relevant icons in the fragment if you want! |
fixed issue ContriHUB#4 . also improved UI
|
@mukul-dev sir please review my Pr... today is last day please |
|
@mukul-dev sir i raised PR on 29th please review it...today is last date of contrihub and hacktoberfest. If not done today i will lose minimum 4 PR bar.. please merge this request. I made all the changes please sir. |
|
Sure @RITIK-CHAUDHRY , I tested couple of times this feature since yesterday and you've done a great job! feature is working almost fine. Why I am saying 'almost', is because there is no validation for empty input field of task (User can mark without writing any tasks which should not be the case). Also, when you restart app, the messages disappear which should remain like with the help of it, user gets to know his/her both tasks are done! Like these there are some small issues. |
|
@mukul-dev thank you so much sir but it is showing approved not merged. |
|
@mukul-dev sir please look into this neither on contrihub nor on hacktoberfest it is showing merged |
|
@RITIK-CHAUDHRY yes.. fixed that! 👍 |
|
@mukul-dev thanks sir... |
Cool! And a very Happy Diwali to you too ! |
Description:
Implement the 2 Priority Tasks for the Day
Related Issue:
fixes issue #4
Type of change:
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Motivation and Context
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Screenshots (if appropriate):
Screen_Recording_20241026_084748_Easy.2.Do.mp4
Checklist:
I have registered myself at Contrihub website.
My code follows the code style of this project.
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
Any dependent changes have been merged and published in downstream modules
Test Configuration:
Firmware version:
Hardware:
Toolchain:
SDK: