[MEV Boost\Builder] execution builder client part 3 #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ajsutton
reviewed
May 5, 2022
...layer/src/main/java/tech/pegasys/teku/ethereum/executionlayer/ExecutionLayerChannelImpl.java
Outdated
Show resolved
Hide resolved
| ExecutionPayloadHeaderSchema executionPayloadHeaderSchema = | ||
| SchemaDefinitionsBellatrix.required(spec.atSlot(slot).getSchemaDefinitions()) | ||
| .getExecutionPayloadHeaderSchema(); | ||
| // validate signature |
There was a problem hiding this comment.
Where does the public key to validate the signature come from? If it's a validator key then it would have to come from state and we won't be able to verify the signature over here - we'd have to pass it all back to the beacon node unchecked which is messy...
There was a problem hiding this comment.
Seems like we should make sure we have a ticket to come back and actually validate the signature here.
ExecutionPayloadContext remove builder api from ExecutionEngineClient Let ExecutionLayerChannelImpl use builder client complete execution engine channel renaming move throttling from channel to clients execution builder CLI ExecutionEngine* to ExecutionLayer*
tbenr
force-pushed
the
integrate_new_builder_client_in_executionLayerChannel
branch
from
dff6cd2 to
dd8c576
Compare
2 tasks
ajsutton
approved these changes
May 10, 2022
| ExecutionPayloadHeaderSchema executionPayloadHeaderSchema = | ||
| SchemaDefinitionsBellatrix.required(spec.atSlot(slot).getSchemaDefinitions()) | ||
| .getExecutionPayloadHeaderSchema(); | ||
| // validate signature |
There was a problem hiding this comment.
Seems like we should make sure we have a ticket to come back and actually validate the signature here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
ExecutionPayloadContextwhich carries the context for a new execution payload has been produced (payloadId,forkChoiceState, andpayloadAttributes). Used to retrieveparentHashand (in later PRs) publicKey of the validator, required in builder apis.related to #5396
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog