-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MEV Boost\Builder] Implement builder_status and health check #5428
[MEV Boost\Builder] Implement builder_status and health check #5428
Conversation
fcc24c6
to
4e5912a
Compare
6968acb
to
e6a4f8e
Compare
19cf133
to
9650c3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm still rethinking about this: having the healthcheck in the ExecutionLayerService
makes ExecutionLayerChannelImpl
unaware of the current status (which makes sense to be aware in case we want to immediately skip to calls based on that)
Let me try implementing it in the Impl and see the difference. It should be a quick one. |
But it could be just a peek in the impl.. let's have a quick chat tomorrow if you don't find a quick nice solution |
ff93385
to
0fa43b8
Compare
…he channel interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Description
Tasks:
Retrieve builder status and implement
isBuilderAvailable
Track builder flow availability
Changes:
ExecutionLayerManager
isBuilderAvailable
implementation toExecutionLayerManager
onSlot
logic toExecutionLayerManager
to track and update the builder flow availabilityFixed Issue(s)
related to #5396
Documentation
doc-change-required
label to this PR if updates are required.Changelog