Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEV Boost\Builder] Implement builder_status and health check #5428

Merged
merged 9 commits into from
May 10, 2022

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented May 4, 2022

PR Description

Tasks:

Retrieve builder status and implement isBuilderAvailable
Track builder flow availability

Changes:

  • Introduced ExecutionLayerManager
  • Added isBuilderAvailable implementation to ExecutionLayerManager
  • Added onSlot logic to ExecutionLayerManager to track and update the builder flow availability

Fixed Issue(s)

related to #5396

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov force-pushed the builder_status_poll branch from fcc24c6 to 4e5912a Compare May 4, 2022 15:17
@StefanBratanov StefanBratanov changed the title Implement builder_status and scheduled polling [MEV Boost\Builder] Implement builder_status and scheduled polling May 4, 2022
@StefanBratanov StefanBratanov changed the title [MEV Boost\Builder] Implement builder_status and scheduled polling [MEV Boost\Builder] Implement builder_status and health check May 4, 2022
@StefanBratanov StefanBratanov force-pushed the builder_status_poll branch 2 times, most recently from 6968acb to e6a4f8e Compare May 5, 2022 07:26
@StefanBratanov StefanBratanov marked this pull request as ready for review May 5, 2022 07:28
@StefanBratanov StefanBratanov changed the title [MEV Boost\Builder] Implement builder_status and health check [MEV Boost\Builder] Implement builder_status and health check and renaming May 5, 2022
@StefanBratanov StefanBratanov changed the title [MEV Boost\Builder] Implement builder_status and health check and renaming [MEV Boost\Builder] Implement builder_status and health check May 5, 2022
@StefanBratanov StefanBratanov marked this pull request as draft May 5, 2022 12:53
@StefanBratanov StefanBratanov marked this pull request as draft May 5, 2022 12:53
@StefanBratanov StefanBratanov force-pushed the builder_status_poll branch from 19cf133 to 9650c3e Compare May 9, 2022 15:04
@StefanBratanov StefanBratanov marked this pull request as ready for review May 9, 2022 15:08
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm still rethinking about this: having the healthcheck in the ExecutionLayerService makes ExecutionLayerChannelImpl unaware of the current status (which makes sense to be aware in case we want to immediately skip to calls based on that)

@StefanBratanov
Copy link
Contributor Author

LGTM but I'm still rethinking about this: having the healthcheck in the ExecutionLayerService makes ExecutionLayerChannelImpl unaware of the current status (which makes sense to be aware in case we want to immediately skip to calls based on that)

Let me try implementing it in the Impl and see the difference. It should be a quick one.

@tbenr
Copy link
Contributor

tbenr commented May 9, 2022

But it could be just a peek in the impl.. let's have a quick chat tomorrow if you don't find a quick nice solution

@StefanBratanov StefanBratanov force-pushed the builder_status_poll branch 2 times, most recently from ff93385 to 0fa43b8 Compare May 10, 2022 10:35
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) May 10, 2022 10:47
@StefanBratanov StefanBratanov merged commit fc7c3e2 into Consensys:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants