Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes report failing when some some structural categories (mainly FSM, ISM, NIC or NNIC) were missing #332

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

Fabian-RY
Copy link
Collaborator

This PR fixes a few reported issues about the report failing when some categories were missing. This PR solves it by:

  • Checking the existence of the plot before plotting it in .Rmd file and pdf generator file
  • Improving some plots to show values of 0 when there are no transcripts in that category. The current implementation ignores those categories

This solves:
#309
#295
#221
#219

Fixes the errors the pull request #324 tries to skip

Copy link
Contributor

@carolinamonzo carolinamonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Fabián :)

@Fabian-RY Fabian-RY merged commit 31883f0 into master Sep 26, 2024
pabloati pushed a commit that referenced this pull request Dec 16, 2024
Fixes report failing when some some structural categories (mainly FSM, ISM, NIC or NNIC) were missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants