Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqanti_qa report fails if there are no isoforms in a category #221

Closed
diekhans opened this issue Aug 27, 2023 · 2 comments
Closed

sqanti_qa report fails if there are no isoforms in a category #221

diekhans opened this issue Aug 27, 2023 · 2 comments
Labels
enhancement New feature or request QC SQ3 Quality Control related issues

Comments

@diekhans
Copy link
Contributor

If a category has no isoforms it, errors like the following occur:

       Quitting from lines 385-393 [p4.s1_p4.s2_p4.s3] (SQANTI3_report.Rmd)
         Error in `ans[ypos] <- rep(yes, length.out = len)[ypos]`:
         ! replacement has length zero
         Backtrace:
           1. ggplotly(p4.s3) %>% layout(showlegend = T, boxmode = "group")
           4. plotly:::ggplotly.ggplot(p4.s3)
           5. plotly::gg2list(...)
           6. plotly (local) ggplotly_build(p)
           7. layout$setup_panel_params()
              ...
          15. ggplot2:::expand_limits_scale(scale, expansion, limits, coord_limits = coord_limits)
          16. ggplot2:::expand_limits_discrete(...)
          17. ggplot2:::expand_limits_discrete_trans(...)
          18. ggplot2:::expand_limits_continuous_trans(...)
          19. base::ifelse(is.na(coord_limits), limits, coord_limits)
         Execution halted

This occurred by filtering all of the isoforms for novel gene categories and re-running sqanti on clean up set of isoforms. I will be submitted a pull request that helped work around this.

@almart7
Copy link
Contributor

almart7 commented Aug 28, 2023

Dear @diekhans thank you so much for your input! We will review it as soon as possible.

@aarzalluz aarzalluz added the QC SQ3 Quality Control related issues label Sep 4, 2023
@aarzalluz
Copy link
Member

@diekhans merged PR #222, fix will be available in next SQANTI3 release. Thanks!

Issue #219 will remain open until we can further enhance the report plots to prevent errors when categories have no isoforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request QC SQ3 Quality Control related issues
Projects
None yet
Development

No branches or pull requests

3 participants