Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose NewClient options to credentials wrappers #111

Merged
merged 1 commit into from
Mar 13, 2024
Merged

feat: expose NewClient options to credentials wrappers #111

merged 1 commit into from
Mar 13, 2024

Conversation

vlnevyhosteny
Copy link
Contributor

I need to apply changes to Transport layer so I would like to expose options of NewClient to GetClient.

@vlnevyhosteny vlnevyhosteny self-assigned this Mar 12, 2024
@vlnevyhosteny vlnevyhosteny marked this pull request as ready for review March 12, 2024 10:23
@vlnevyhosteny vlnevyhosteny requested a review from jirwin as a code owner March 12, 2024 10:23
martinalbert
martinalbert approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@martinalbert martinalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Made me think if we even want to have a default logger option or left it upon developer consideration.

@vlnevyhosteny vlnevyhosteny mentioned this pull request Mar 13, 2024
Merged
@ggreer ggreer merged commit 86b1aff into main Mar 13, 2024
4 checks passed
@ggreer ggreer deleted the feat/options-for-get-uhttp-client branch March 13, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinalbert martinalbert martinalbert approved these changes

@ggreer ggreer Awaiting requested review from ggreer

@jirwin jirwin Awaiting requested review from jirwin jirwin is a code owner

Assignees

@vlnevyhosteny vlnevyhosteny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlnevyhosteny @martinalbert @ggreer