Feat/initial #2
Merged
Feat/initial #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreer
reviewed
Mar 18, 2024
pkg/connector/users.go
Outdated
|
|
||
| func (o *userBuilder) ResourceType(ctx context.Context) *v2.ResourceType { | ||
| return userResourceType | ||
| } | ||
|
|
||
| func getUserStatus(user *panorama.User) v2.UserTrait_Status_Status { | ||
| if user.Disabled { | ||
| return v2.UserTrait_Status_STATUS_ENABLED |
There was a problem hiding this comment.
I think this logic is reversed :)
There was a problem hiding this comment.
Copilot 🙃 Resolved in 1fc371d
pkg/panorama/user.go
Outdated
| } | ||
|
|
||
| func (c *Client) GetUser(ctx context.Context, name string) (*User, *http.Response, error) { | ||
| stringUrl, err := url.JoinPath(c.baseUrl, ApiPath) |
There was a problem hiding this comment.
I see stringUrl, err := url.JoinPath(c.baseUrl, ApiPath) at the start of every function. Maybe we should just save the API URL since it's the same for every request?
ggreer
reviewed
Mar 18, 2024
| return &Connector{}, nil | ||
| func New(ctx context.Context, panoramaUrl, username, password string, ignoreBadCertificate bool) (*Panorama, error) { | ||
| clientOptions := []uhttp.Option{} | ||
| if ignoreBadCertificate { |
There was a problem hiding this comment.
We should probably log a warning here.
ggreer
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by ConductorOne/baton-sdk#112 ConductorOne/baton-sdk#111
Closes #1