Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation action changes #4719

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Animation action changes #4719

merged 1 commit into from
Aug 23, 2022

Conversation

LalithaNadimpalli
Copy link
Contributor

@LalithaNadimpalli LalithaNadimpalli commented Aug 11, 2022

StopAnimationActivity and StartAnimationAction dependency properties are incorrectly registered

Fixes #4695

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

StopAnimationActivity and StartAnimationAction dependency properties are incorrectly registered #4695
@ghost
Copy link

ghost commented Aug 11, 2022

Thanks LalithaNadimpalli for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi August 11, 2022 20:48
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Aug 23, 2022
@michael-hawker michael-hawker added this to the 7.1.3 milestone Aug 23, 2022
@michael-hawker michael-hawker merged commit b5d0f26 into main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animations 🏮 bug 🐛 An unexpected issue that highlights incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StopAnimationActivity and StartAnimationAction dependency properties are incorrectly registered
3 participants