Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StopAnimationActivity and StartAnimationAction dependency properties are incorrectly registered #4695

Closed
billyzkid opened this issue Jul 30, 2022 · 3 comments · Fixed by #4719
Closed

StopAnimationActivity and StartAnimationAction dependency properties are incorrectly registered #4695

billyzkid opened this issue Jul 30, 2022 · 3 comments · Fixed by #4719
Assignees
@LalithaNadimpalli
Labels
animations 🏮 bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥
Milestone
7.1.3

Comments

@billyzkid
Copy link

billyzkid commented Jul 30, 2022 •
edited
Loading

It looks like these two dependency properties are registered with the wrong owner type.

WindowsCommunityToolkit/Microsoft.Toolkit.Uwp.UI.Animations/Xaml/Activities/StopAnimationActivity.cs

Line 32 in 63cbb4a

typeof(StartAnimationActivity),

WindowsCommunityToolkit/Microsoft.Toolkit.Uwp.UI.Animations/Xaml/Activities/StopAnimationActivity.cs

Line 50 in 63cbb4a

typeof(StartAnimationActivity),

Here's another one:

WindowsCommunityToolkit/Microsoft.Toolkit.Uwp.UI.Behaviors/Animations/StartAnimationAction.cs

Line 50 in 55723da

typeof(StartAnimationActivity),

@ghost ghost added the needs triage 🔍 label Jul 30, 2022
@ghost
Copy link

ghost commented Jul 30, 2022

Hello billyzkid, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@billyzkid billyzkid changed the title StopAnimationActivity dependency properties are incorrectly registered StopAnimationActivity and StartAnimationAction dependency properties are incorrectly registered Jul 30, 2022
@LalithaNadimpalli LalithaNadimpalli added bug 🐛 An unexpected issue that highlights incorrect behavior and removed needs triage 🔍 labels Aug 1, 2022
@Sergio0694
Copy link
Member

PandaFacepalmGIF

@michael-hawker michael-hawker added this to the 7.1.3 milestone Aug 9, 2022
LalithaNadimpalli added a commit that referenced this issue Aug 11, 2022
@LalithaNadimpalli
Animation action changes
2e578f7 
StopAnimationActivity and StartAnimationAction dependency properties are incorrectly registered #4695
@LalithaNadimpalli LalithaNadimpalli mentioned this issue Aug 11, 2022
Merged
13 tasks
@LalithaNadimpalli
Copy link
Contributor

Hi, Thank you for raising the issue. Created a PR with the necessary changes

@ghost ghost added the In-PR 🚀 label Aug 23, 2022
michael-hawker added a commit that referenced this issue Aug 23, 2022
@michael-hawker
Merge pull request #4719 from CommunityToolkit/AnimationActivity(#4695)
b5d0f26 
Animation action changes
Repository owner moved this from In Progress to Done in Windows Community Toolkit Aug 23, 2022
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Aug 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LalithaNadimpalli LalithaNadimpalli

Labels
animations 🏮 bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥
Projects
Windows Community Toolkit
Status: Done
Milestone
7.1.3
Development

Successfully merging a pull request may close this issue.

Animation action changes CommunityToolkit/WindowsCommunityToolkit
4 participants
@billyzkid @Sergio0694 @michael-hawker @LalithaNadimpalli