-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Standard extraction #4395
.NET Standard extraction #4395
Conversation
…to dev/NETStandardExtraction
Thanks XAML-Knight for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deleted code seems ok, but there's a few things to resolve still.
Also you forgot to delete the .NET solution filter file 🙂
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better, we're almost there! 😄
Remember to also delete the solution filter!
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Deleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @Sergio0694?
@michael-hawker Was planning on taking a look tomorrow morning just to double check again 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@michael-hawker Feel free to squash-merge this and/or to decide how to proceed with respect to other PRs.
The changes here are good on their own, so good to go for me 👍
The .NET Standard Code has been moved to a new repo, and is no longer meant to be maintained by the Windows Community Toolkit repo. This PR is the removal of said .NET Standard code from the Toolkit.
Fixes #4382
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The Community Toolkit contains .NET Standard code
What is the new behavior?
.NET Standard code is removed from the toolkit. Specifically, it's these projects and associated unit tests that are being removed:
Code that previously depended on the
Microsoft.Toolkit
code was updated to instead grab from the Microsoft.Toolkit.* NuGet packages.PR Checklist
Please check if your PR fulfills the following requirements:
Other information