Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Standard extraction #4395

Conversation

XAML-Knight
Copy link
Contributor

@XAML-Knight XAML-Knight commented Nov 22, 2021

The .NET Standard Code has been moved to a new repo, and is no longer meant to be maintained by the Windows Community Toolkit repo. This PR is the removal of said .NET Standard code from the Toolkit.

Fixes #4382

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

The Community Toolkit contains .NET Standard code

What is the new behavior?

.NET Standard code is removed from the toolkit. Specifically, it's these projects and associated unit tests that are being removed:

  • Microsoft.Toolkit
  • Microsoft.Toolkit.Diagnostics
  • Microsoft.Toolkit.HighPerformance
  • Microsoft.Toolkit.Mvvm
  • Microsoft.Toolkit.Mvvm.SourceGenerators

Code that previously depended on the Microsoft.Toolkit code was updated to instead grab from the Microsoft.Toolkit.* NuGet packages.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
    • Tests which were duplicating those appearing in the dotnet repo have been removed
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Nov 22, 2021

Thanks XAML-Knight for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi November 22, 2021 21:50
@XAML-Knight XAML-Knight changed the title 🚧 🚧 .NET Standard extraction (after rebase) 🚧 .NET Standard extraction (after rebase) Nov 23, 2021
@XAML-Knight XAML-Knight changed the title 🚧 .NET Standard extraction (after rebase) 🚧 .NET Standard extraction Nov 23, 2021
@XAML-Knight XAML-Knight changed the title 🚧 .NET Standard extraction .NET Standard extraction Nov 29, 2021
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deleted code seems ok, but there's a few things to resolve still.
Also you forgot to delete the .NET solution filter file 🙂

Microsoft.Toolkit.Uwp.SampleApp/App.xaml Outdated Show resolved Hide resolved
Microsoft.Toolkit.Uwp/Microsoft.Toolkit.Uwp.csproj Outdated Show resolved Hide resolved
build/build.cake Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Dec 1, 2021

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, we're almost there! 😄
Remember to also delete the solution filter!

@ghost
Copy link

ghost commented Dec 1, 2021

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

@XAML-Knight
Copy link
Contributor Author

... Remember to also delete the solution filter!

Deleted

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Sergio0694?

@michael-hawker michael-hawker added .NET Components which are .NET based (non UWP specific) build 🔥 CI/pipeline 🔬 and removed needs attention 👋 labels Dec 1, 2021
@michael-hawker michael-hawker added this to the 7.2/8.0? milestone Dec 1, 2021
@Sergio0694
Copy link
Member

@michael-hawker Was planning on taking a look tomorrow morning just to double check again 😄
Happy to take care of merging it then if you want.

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@michael-hawker Feel free to squash-merge this and/or to decide how to proceed with respect to other PRs.
The changes here are good on their own, so good to go for me 👍

@michael-hawker michael-hawker merged commit 8be7328 into CommunityToolkit:main Dec 2, 2021
@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 🔥 CI/pipeline 🔬 .NET Components which are .NET based (non UWP specific)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove .NET Standard Code from Repo
3 participants