Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .NET Standard Code from Repo #4382

Closed
michael-hawker opened this issue Nov 15, 2021 · 2 comments · Fixed by #4395
Closed

Remove .NET Standard Code from Repo #4382

michael-hawker opened this issue Nov 15, 2021 · 2 comments · Fixed by #4395
Assignees
Labels
build 🔥 CI/pipeline 🔬 Completed 🔥 .NET Components which are .NET based (non UWP specific)
Milestone

Comments

@michael-hawker
Copy link
Member

Describe the problem this feature would solve

We've moved our .NET Standard Code to now be the .NET Community Toolkit. 🎉🎉🎉

Its new home is now in this repo here.

Describe the solution

We migrated all the history over there as well, so now we just need to remove the following packages from our repo to complete the transfer:

  • Microsoft.Toolkit
  • Microsoft.Toolkit.Diagnostics
  • Microsoft.Toolkit.HighPerformance
  • Microsoft.Toolkit.Mvvm
  • Microsoft.Toolkit.Mvvm.SourceGenerators

For anything that depends on Microsoft.Toolkit still we should update it to grab the CommunityToolkit.Common package from the MainLatest feed instead.

I believe we can also simplify our tests a bit potentially, right @Sergio0694?

@XAML-Knight mind taking a stab at opening a PR for this migration step removing these packages here in this repo? Thanks!

@michael-hawker michael-hawker added build 🔥 CI/pipeline 🔬 .NET Components which are .NET based (non UWP specific) labels Nov 15, 2021
@Sergio0694
Copy link
Member

Sergio0694 commented Nov 15, 2021

@michael-hawker Just to double check, we do plan to hold on this until we push 7.1.2 out, correct?
Otherwise we'll have no way to do so, unless we branched off of rel/7.1.1 I guess? 🤔

"I believe we can also simplify our tests a bit potentially, right @Sergio0694?"

Yes, we can simplify tests a whole lot like I did in the dotnet repo as well.
We can remove all the shared projects and just aggregate the UWP test projects, for instance, and do some cleanup.
The infrastructure is extremely clean now for dotnet and I think there's plenty of room for improvements here too now 🎉

@michael-hawker
Copy link
Member Author

@Sergio0694 we can pick up an intermediate build at the moment, but yes we'd base off of 7.1.2 eventually. If you plan to put that together this week, then we can coordinate too, especially if we update for WinUI 3 1.0. FYI @azchohfi.

@ghost ghost added In-PR 🚀 and removed In-PR 🚀 labels Nov 19, 2021
@ghost ghost added the In-PR 🚀 label Nov 23, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Dec 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2022
@michael-hawker michael-hawker added this to the 7.1.3 milestone Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build 🔥 CI/pipeline 🔬 Completed 🔥 .NET Components which are .NET based (non UWP specific)
Projects
Status: Done
3 participants