Add Property panel for ViewportBehavior #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAML-Knight
requested review from
Sergio0694,
michael-hawker and
shweaver-MSFT
|
Thanks XAML-Knight for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested a review
from 
ghost
added
bug 🐛
Microsoft.Toolkit.Uwp.UI.Behaviors/Viewport/ViewportBehavior.Properties.cs
Show resolved
Hide resolved
| @@ -14,7 +14,7 @@ | |||
| Height="200" | |||
| Background="Gray"> | |||
| <interactivity:Interaction.Behaviors> | |||
| <behaviors:ViewportBehavior x:Name="ViewportBehavior" /> | |||
| <behaviors:ViewportBehavior x:Name="ViewportBehavior" IsAlwaysOn="@[IsAlwaysOn:Bool:True]" /> | |||
There was a problem hiding this comment.
Maybe rather than a toggle we just want this to be on by default (for the sample)?
Microsoft.Toolkit.Uwp.UI.Behaviors/Viewport/ViewportBehavior.Properties.cs
Show resolved
Hide resolved
|
Addressed requested changes during PR, which leads to Properties panel no longer being shown |
michael-hawker
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4193
PR Type
Bugfix
What is the current behavior?
No Properties panel appears when viewing the
ViewportBehaviorSample Page, as well as the fact that the event logging (within the page) was not occurring as often as it should have been, if theIsAlwaysOnbool property was set totrue.What is the new behavior?
A Properties panel now appears for the ViewportBehavior Sample Page, with a toggle switch for
IsAlwaysOn, and event logging occurs more frequently, as expected.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Attempted to properly address the following code, but ran into issues with the logging completely shutting down, regardless of setting the
IsAlwaysOnproperty astrueor not:Interaction.GetBehaviors(obj.AssociatedObject).Remove(obj);Even when trying to complete the pattern of adding or removing from the underlying
BehaviorCollection, the associated event becomes unsubscribed, and then no more logging occurs, regardless.