Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewportBehavior logging events only fire once #4193

Closed
3 of 9 tasks
XAML-Knight opened this issue Aug 23, 2021 · 3 comments · Fixed by #4320
Closed
3 of 9 tasks

ViewportBehavior logging events only fire once #4193

XAML-Knight opened this issue Aug 23, 2021 · 3 comments · Fixed by #4320
Assignees
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 need more info 📌 sample bug 🐛
Milestone

Comments

@XAML-Knight
Copy link
Contributor

XAML-Knight commented Aug 23, 2021

Describe the bug

When interacting with the ViewportBehavior Sample page, notice that the events that log the user interaction (i.e., element is scrolled into view, then scrolled out, then back in, etc.) only get logged once to the Log display. After the visual/UI element is scrolling into view, and then fully in view, no more logging occurs, regardless of user interaction.

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

  • Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)

Steps to reproduce the behavior:

  1. Run Sample App
  2. Go to ViewportBehavior
  3. Scroll down to get the visual element to be Entering viewport in the Logs display section
  4. Keep scrolling down to get the visual element to be fully Entered viewport in the Logs display section
  5. Continue to scroll up or down, into or completely out of view, and notice that nothing else ever gets logged in the Logs display section

Expected behavior

Continuous logging should be happening in the Logs display section, as relevant user interaction continues to happen.

Screenshots

Environment

Device form factor:

  • Desktop
  • Xbox
  • Surface Hub
  • IoT

Visual Studio version:

  • 2017 (15.{minor_version})
  • 2019 (16.10.3), Debug, x64
  • 2022 (17.{minor_version})

Additional context

@XAML-Knight XAML-Knight added the bug 🐛 An unexpected issue that highlights incorrect behavior label Aug 23, 2021
@ghost ghost added the needs triage 🔍 label Aug 23, 2021
@ghost
Copy link

ghost commented Aug 23, 2021

Hello XAML-Knight, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@michael-hawker
Copy link
Member

@XAML-Knight I think there's a property about preventing or not preventing (forget which) of detaching the events once they fire. I imagine you need to check if that's on or not and see if it works in the other mode as you would expect. So this may be by design?

@XAML-Knight
Copy link
Contributor Author

XAML-Knight commented Aug 25, 2021

@XAML-Knight I think there's a property about preventing or not preventing (forget which) of detaching the events once they fire. I imagine you need to check if that's on or not and see if it works in the other mode as you would expect. So this may be by design?

Yes, the property in question (IsAlwaysOn) is off, by default. Not sure why there would be a 'Clear' button, then, when the control only logs, from the end user's perspective, 2 log messages. I'd suggest exposing IsAlwaysOn as a toggle button setting/property, that a user can turn off or on.

@XAML-Knight XAML-Knight added this to the 7.1.1 milestone Oct 7, 2021
@XAML-Knight XAML-Knight self-assigned this Oct 7, 2021
@ghost ghost added the In-PR 🚀 label Oct 14, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Oct 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 need more info 📌 sample bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants