Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/implicit animations reset #4274

Conversation

Sergio0694
Copy link
Member

Fixes #4273

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Setting the animations to null doesn't reset them.

What is the new behavior?

Setting the animations to null clears the animations for the target element.

Sample

DvAmCOz7pu.mp4

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior animations 🏮 labels Sep 24, 2021
@ghost
Copy link

ghost commented Sep 24, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Rosuavio September 24, 2021 16:05
@XAML-Knight
Copy link
Contributor

What ... a video without music? :o

@michael-hawker michael-hawker merged commit fef65a5 into CommunityToolkit:main Sep 25, 2021
@Sergio0694 Sergio0694 deleted the bugfix/implicit-animations-reset branch September 25, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animations 🏮 bug 🐛 An unexpected issue that highlights incorrect behavior hotfix 🌶 priority 🚩
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting the implicit animations to null doesn't reset the animations
3 participants