Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the implicit animations to null doesn't reset the animations #4273

Closed
5 of 19 tasks
Sergio0694 opened this issue Sep 24, 2021 · 1 comment · Fixed by #4274
Closed
5 of 19 tasks

Setting the implicit animations to null doesn't reset the animations #4273

Sergio0694 opened this issue Sep 24, 2021 · 1 comment · Fixed by #4274
Labels
animations 🏮 bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 priority 🚩
Milestone

Comments

@Sergio0694
Copy link
Member

Describe the bug

When setting any of the implicit animations properties (eg. Implicit.Animations) to null after having previously set them, that doesn't actually reset the animations, but instead it does nothing. This also means that implicit animations can't be removed from eg. a visual state setter by setting the value of the attached property to {x:Null}.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Set some implicit animations to a UI element
  2. Then set them to null (either in XAML or code behind)
  3. Observe how the animations are still being played

Expected behavior

The animations should be removed when the relative property is set to null.

Environment

NuGet Package(s): 7.1.0

Package Version(s):

Windows 10 Build Number:

  • Fall Creators Update (16299)
  • April 2018 Update (17134)
  • October 2018 Update (17763)
  • May 2019 Update (18362)
  • May 2020 Update (19041)
  • Insider Build ({build_number})

App min and target version:

  • Fall Creators Update (16299)
  • April 2018 Update (17134)
  • October 2018 Update (17763)
  • May 2019 Update (18362)
  • May 2020 Update (19041)
  • Insider Build ({build_number})

Device form factor:

  • Desktop
  • Xbox
  • Surface Hub
  • IoT

Visual Studio version:

  • 2017 (15.{minor_version})
  • 2019 (16.{minor_version})
  • 2022 (17.{minor_version})
@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior animations 🏮 labels Sep 24, 2021
@ghost ghost added the needs triage 🔍 label Sep 24, 2021
@ghost
Copy link

ghost commented Sep 24, 2021

Hello Sergio0694, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@ghost ghost added the In-PR 🚀 label Sep 24, 2021
@michael-hawker michael-hawker added this to the 7.1.1 milestone Sep 24, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Sep 25, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
animations 🏮 bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 priority 🚩
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants