Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a parameter for configuration(Debug/Release) on the cake build script #4145

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

azchohfi
Copy link
Contributor

Fixes #4144

This adds a parameter to the build.cake file to be able to easily build everything in debug mode.

PR Type

What kind of change does this PR introduce?

  • Feature
  • Build or CI related changes

What is the current behavior?

Can only run the build script in Release.

What is the new behavior?

Builds in Release mode by default, but you can run "build.ps1 -configuration debug" to build everything in debug.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Jul 29, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 48 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker michael-hawker added this to the 7.1 milestone Jul 29, 2021
@azchohfi azchohfi merged commit 7b49dae into main Jul 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the debugBuild branch July 29, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugging the Toolkit's UI tests is hard since we build in Release mode
2 participants