Infinite Canvas dropdown font selector 2 #3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
|
This is almost there, but for some reason setting |
|
@Kyaa-dost @azchohfi @salmanmkc if you guys don't mind taking a look at this. |
Rosuavio
added
auto merge ⚡
Completed 🔥
controls 🎛️
for-review 📖
|
Hello @RosarioPulella! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…s.xaml Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
Note: Control.FontSize is a double, perhaps win2d should allign with this and this should be changed to doulbe then.
or on enter for text input
michael-hawker
approved these changes
Apr 20, 2021
7 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued off of #3211
User can now input a font size via typed text and not only selection from out provided sizes.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
You have to enter a font size with text in the textbox, I used the standard font sizes that are given in Microsoft Office PowerPoint (increments from 8 to 96).
What is the new behavior?
User can select the font size themselves now
PR Checklist
Please check if your PR fulfills the following requirements:
Other information