Infinite Canvas dropdown font selector instead of textbox #3211
Conversation
update fork
|
Thanks salmanmkc for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
There was a problem hiding this comment.
@salmanmkc Thanks for the PR! Just delete the duplicate size 48. Everything else looks good!
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Thanks for spotting that! Fixed! 😊 |
|
This is a breaking change. It should go to 7.0, not 6.1. |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment. |
…s.xaml Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
|
I committed your change you made @michael-hawker, did I need to look into conditional properties? |
|
oh I see for isEditable, I will try look into that and utilise strings there |
|
@salmanmkc once #3478 is merged you won't have to worry about a conditional here. So once that gets merged, let's update this PR. |
|
Build seems to be failing now, not sure what the issue is |
|
Same with the master branch, I think it's just my user login |
|
@salmanmkc last build status seemed fine to me, updating here. What are you seeing? |
|
@salmanmkc update on this one? |
|
@salmanmkc the build is running fine. Can you please check one more time? 😊 |
Yes, will have a look now |
|
Hi @salmanmkc, I'm looking to review this PR, do you mind resolving the conflicts? Also if you can add back in the |
|
@salmanmkc is there any update on this? |
|
Moving to 7.1 |
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 --> <!-- 📝 It is preferred if you keep the "☑️ Allow edits by maintainers" checked in the Pull Request Template as it increases collaboration with the Toolkit maintainers by permitting commits to your PR branch (only) created from your fork. This can let us quickly make fixes for minor typos or forgotten StyleCop issues during review without needing to wait on you doing extra work. Let us help you help us! 🎉 --> ## Continued off of #3211 <!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. --> <!-- Add a brief overview here of the feature/bug & fix. --> User can now input a font size via typed text and not only selection from out provided sizes. ## PR Type What kind of change does this PR introduce? <!-- Please uncomment one or more that apply to this PR. --> <!-- - Bugfix --> - Feature <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> You have to enter a font size with text in the textbox, I used the standard font sizes that are given in Microsoft Office PowerPoint (increments from 8 to 96). ## What is the new behavior? <!-- Describe how was this issue resolved or changed? --> User can select the font size themselves now ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tested code with current [supported SDKs](../readme.md#supported) - [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link --> - [ ] Sample in sample app has been added / updated (for bug fixes / features) - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets) - [ ] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/windows-toolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc... - [ ] Tests for the changes have been added (for bug fixes / features) (if applicable) - [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*) - [ ] Contains **NO** breaking changes <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. --> ## Other information
|
Closing this as we finalized this in #3914. |
Fixes
No issue that I know of, just a change
PR Type
What kind of change does this PR introduce?
A UI change
What is the current behavior?
You have to enter a font size with text in the textbox, I used the standard font sizes that are given in Microsoft Office PowerPoint (increments from 8 to 96).
What is the new behavior?
User can select the font size themselves now
Screenshots
Before
Textbox to change the font size
After
Showing the ComboBox collapsed
Expanded ComboBox
PR Checklist
Please check if your PR fulfills the following requirements:
Other information