-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MetadataControl
#3686
Add MetadataControl
#3686
Conversation
Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Thanks @vgromfeld, this seems like an interesting control/use-case. Mind opening up a tracking issue as well for discussion on API usage? Going to mark as draft for now as well. |
Microsoft.Toolkit.Uwp.UI.Controls/MetadataControl/MetadataControl.cs
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls/MetadataControl/MetadataControl.cs
Outdated
Show resolved
Hide resolved
@Kyaa-dost @RosarioPulella want to take this for a spin and add any thoughts or sign-off? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀 🚀
Hello @RosarioPulella! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Hopefully the separating glyph is changeable |
Thanks @mdtauk for taking a look, yup there's a |
@vgromfeld when you have a chance can you open a docs PR for this? There's a template here Thanks! |
Fixes #3688
Adds a control to display metadata separated by bullets like done in Groove Music or the Store.
The metadata list can contain actionable links.
Groove
Store
PR Type
What kind of change does this PR introduce?
What is the new behavior?
I've added
MetadataControl
. It aggregates strings and commands separated by bullets ("•" / U+2022) in aTextBlock
.The commands are represented using
Hyperlink
items.It receives the items to display as
MetadataUnit
s through itsMetadataControl.MetadataUnits
property.PR Checklist
Please check if your PR fulfills the following requirements:
Other information