Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add a control to display a list of metadata #3688

Closed
vgromfeld opened this issue Jan 25, 2021 · 1 comment · Fixed by #3686
Closed

[Feature] Add a control to display a list of metadata #3688

vgromfeld opened this issue Jan 25, 2021 · 1 comment · Fixed by #3686
Labels
Completed 🔥 controls 🎛️ feature request 📬 A request for new changes to improve functionality
Milestone

Comments

@vgromfeld
Copy link
Contributor

Describe the problem this feature would solve

Some application like Groove or the Store are using a control to display metadata separated by bullets with some of them that can be actionable (navigate to dedicated pages)
image
image

Describe the solution

We should add to the toolkit a control that would:

  • Display a list of items are a bullet separated list of stings
  • Display hyperlinks for the actionable items in the list

This control will have to be fully accessible. The "default" bullet control is skipped when using screen reader. The control should generate a screen reader compliant representation of its content (replacing the bullet by a coma is usually enough).

@vgromfeld vgromfeld added the feature request 📬 A request for new changes to improve functionality label Jan 25, 2021
@ghost
Copy link

ghost commented Jan 25, 2021

Hello, 'vgromfeld! Thanks for submitting a new feature request. I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future!

@vgromfeld vgromfeld changed the title [Feature] [Feature] Add a control to display a list of metadata Jan 25, 2021
@vgromfeld vgromfeld mentioned this issue Jan 25, 2021
8 tasks
@ghost ghost added the In-PR 🚀 label Jan 25, 2021
@michael-hawker michael-hawker added this to the 7.1 milestone Feb 4, 2021
@ghost ghost closed this as completed in #3686 Jun 16, 2021
@ghost ghost removed the In-PR 🚀 label Jun 16, 2021
ghost pushed a commit that referenced this issue Jun 16, 2021
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 -->

<!-- 📝 It is preferred if you keep the "☑️ Allow edits by maintainers" checked in the Pull Request Template as it increases collaboration with the Toolkit maintainers by permitting commits to your PR branch (only) created from your fork.  This can let us quickly make fixes for minor typos or forgotten StyleCop issues during review without needing to wait on you doing extra work. Let us help you help us! 🎉 -->


## Fixes #3688
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->

Adds a control to display metadata separated by bullets like done in Groove Music or the Store. 
The metadata list can contain actionable links.

**Groove**
![groove](https://user-images.githubusercontent.com/20152272/105519998-66aa6100-5cda-11eb-891a-4598ad5becf4.png)

**Store**
![store](https://user-images.githubusercontent.com/20152272/105520090-817cd580-5cda-11eb-8bf1-36afbc2fe435.png)

## PR Type
What kind of change does this PR introduce?
- Feature

## What is the new behavior?
I've added `MetadataControl`. It aggregates strings and commands separated by bullets ("•" / U+2022) in a `TextBlock`.
The commands are represented using `Hyperlink` items. 
It receives the items to display as `MetadataUnit`s through its `MetadataControl.MetadataUnits` property.

## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [x] Sample in sample app has been added / updated (for bug fixes / features)
    - [x] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [ ] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/windows-toolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [x] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [x] Contains **NO** breaking changes

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. 
     Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->


## Other information
![image](https://user-images.githubusercontent.com/20152272/105520377-f0f2c500-5cda-11eb-9116-8447969d1cdd.png)
@ghost ghost added the Completed 🔥 label Jun 16, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Completed 🔥 controls 🎛️ feature request 📬 A request for new changes to improve functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants