-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out Smoke Tests and Unit Tests into a separate Jobs #3617
Conversation
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Different jobs might (will) be executed on different machines on ADO Hosted environments, so to do this, you would need to make the artifacts from the build system available to the tests. |
When I merge the UI Tests, I should have a split condition to include package references for TAEF but keep the Project Reference for MSTest, this means we could split it out as a separate job to run in parallel. |
1998124
to
8e5b8a0
Compare
Alright, cleaned up the YAML edits, think this should be good to run the Smoke Tests as a separate Job now. 🤞 Will check in the morning and look at splitting out the UI Integration Tests as another Job (as they're currently bundled together under the Unit Tests) as well doing the file measuring for the Smoke Tests, have some insights on that one. I don't think it should be too hard. 🤞 |
5809a23
to
367a09a
Compare
Makes it easier to see output from only UI tests without knowing a scroll point in the log
4d38eda
to
36ccb53
Compare
…and package sizes Provides a more human readible way to understand our package sizes and dependencies against a baseline blank application See more info in CommunityToolkit#3600 for potential improvements
0215530
to
b68d903
Compare
Still some improvements we could do for #3600, but this gives us at least a starting point, so we can look to merge this in first and get back to improving things more later after 7.0. For now, this should give us a good human-readable breakdown of both dependencies and the footprint size on an application. Definitely some interesting finds... FYI @RosarioPulella |
Aww, it doesn't colorize in Azure (seeing if I can get https://developercommunity.visualstudio.com/content/problem/440605/write-host-foreground-color-with-powershell-task-i.html re-opened), but worked like a charm still! This is ready for review for the first version of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than some superfluous white space, Looks good!
Co-authored-by: Rosario Pulella <[email protected]>
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@azchohfi this is all set to go for now. Look good to you? |
Fixes #3560
This PR does the following:
PR Type
What is the current behavior?
Everything is done in one big job.
What is the new behavior?
We have more granularity on our pipeline
PR Checklist
Please check if your PR fulfills the following requirements:
Other information