Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Create 2nd Stage/Job for Smoke Tests #3560

Closed
michael-hawker opened this issue Nov 10, 2020 · 3 comments · Fixed by #3617
Closed

[Build] Create 2nd Stage/Job for Smoke Tests #3560

michael-hawker opened this issue Nov 10, 2020 · 3 comments · Fixed by #3617
Labels
build 🔥 CI/pipeline 🔬 Completed 🔥 help wanted Issues identified as good community contribution opportunities
Milestone
7.0

Comments

@michael-hawker
Copy link
Member

I also thought we had discussed before, but could we split the smoke test part into a 2nd job/stage? That'd make the build report and publish to the PR feed as a separate check from the smoke test itself which could run after, eh?

image

Basically showing up as a third line, so in this last case, we'd have seen the build and the release to our feed succeed, but then the smoke test line (not here) fail?

Originally posted by @michael-hawker in #3450 (comment)
@ghost ghost added the needs triage 🔍 label Nov 10, 2020
@ghost
Copy link

ghost commented Nov 10, 2020

Hello michael-hawker, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@michael-hawker michael-hawker added this to the 7.0 milestone Nov 10, 2020
@michael-hawker michael-hawker added help wanted Issues identified as good community contribution opportunities and removed needs triage 🔍 labels Nov 10, 2020
@michael-hawker
Copy link
Member Author

All the work for the smoke tests are done, this should just be some YAML configuration for splitting the step out into it's own stage or something to get it to appear as a new line item after the build.

@michael-hawker michael-hawker mentioned this issue Nov 10, 2020
Merged
7 tasks
@michael-hawker
Copy link
Member Author

michael-hawker commented Dec 4, 2020 •
edited
Loading

Also see for reference what PowerToys is planning to adopt from Terminal: microsoft/PowerToys#7162 (Edit: ah misunderstood this is for releases not pipelines, so probably not useful as we have a simpler release pipe.)

@michael-hawker michael-hawker mentioned this issue Dec 4, 2020
Closed
michael-hawker added a commit to michael-hawker/UWPCommunityToolkit that referenced this issue Dec 10, 2020
@michael-hawker
Split out Unit Tests and Smoke Tests as separate Jobs in the Pipeline…
ab8abf2 
… for CommunityToolkit#3560
@michael-hawker michael-hawker mentioned this issue Dec 10, 2020
Merged
11 tasks
@ghost ghost added the In-PR 🚀 label Dec 10, 2020
michael-hawker added a commit to michael-hawker/UWPCommunityToolkit that referenced this issue Dec 11, 2020
@michael-hawker
Split out Unit Tests and Smoke Tests as separate Jobs in the Pipeline…
9221e49 
… for CommunityToolkit#3560
@ghost ghost closed this as completed in #3617 Dec 15, 2020
ghost pushed a commit that referenced this issue Dec 15, 2020
Split out Smoke Tests and Unit Tests into a separate Jobs (#3617)
3790024 
## Fixes #3560
This PR does the following:
- [x] Split our tests out of the single Job into two separates Jobs, these can hopefully run in parallel? We should also get separate status checks for each job? (Will see when we run this here.)
- [x] Adds a UWP Baseline Blank App, this will be useful for #3600 to compare what the minimum app size is currently with no extra dependencies.
- [x] Split out UI Tests as a separate step from the Unit Tests
- [x] Add Application Metrics Report to Smoke Tests #3600 (could be a separate PR I suppose)

## PR Type
- Build or CI related changes

## What is the current behavior?
Everything is done in one big job.

## What is the new behavior?
We have more granularity on our pipeline

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [ ] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [ ] Contains **NO** breaking changes

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. 
     Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->


## Other information
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Dec 15, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Feb 13, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
build 🔥 CI/pipeline 🔬 Completed 🔥 help wanted Issues identified as good community contribution opportunities
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

Split out Smoke Tests and Unit Tests into a separate Jobs michael-hawker/UWPCommunityToolkit
1 participant
@michael-hawker