Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 7, enable WASM optimizations #485

Merged
merged 46 commits into from
Oct 24, 2023
Merged

Upgrade to .NET 7, enable WASM optimizations #485

merged 46 commits into from
Oct 24, 2023

Conversation

Arlodotexe
Copy link
Member

Companion PR to CommunityToolkit/Tooling-Windows-Submodule#117, which should be closed before merging this.

As noted:

Any codebase consuming the tooling repo will need to be adjusted to account for the new nullable annotations and analyzers added between netstandard2.0 and net7.0.

This PR pulls in the .NET 7 upgrade and fixes the new warnings and errors that appeared in our codebase as a result.

@Arlodotexe Arlodotexe added enhancement Improvement to an existing feature Uno Issues related to Uno Platform WASM Bugs related to working with WASM/Codespaces CI/pipeline 🔬 dev loop ➰ For issues that impact the core dev-loop of building experiments labels Aug 2, 2023
@michael-hawker
Copy link
Member

@Arlodotexe can you see if any of the open PRs need updating from this? Thanks!

@michael-hawker
Copy link
Member

Wasn't sure why GitHub wasn't reporting anything, had to dig-in to the Actions page for the last build and see the 'Startup Failure' seems like one of the actions isn't on the allowlist, going to fix that.

@michael-hawker
Copy link
Member

Going to close and re-open to kick off CI again

@michael-hawker
Copy link
Member

@Arlodotexe CI is running again, but something up with the call to the pack script:

   2 |  ./PackEachExperiment.ps1 -extraBuildProperties "pull-485.1577"
     |                           ~~~~~~~~~~~~~~~~~~~~~
     | A parameter cannot be found that matches parameter name 'extraBuildProperties'.

Maybe the sub-module isn't updated or something? Should hopefully be an easy fix of some sort either way.

@Jay-o-Way
Copy link
Contributor

Hey guys, check out the MS video: "Upgrade your .NET projects with Visual Studio"
https://build.microsoft.com/en-US/sessions/c5bf6653-f0de-4091-a139-caf7904300c6

@Arlodotexe Arlodotexe enabled auto-merge October 24, 2023 19:21
@Arlodotexe Arlodotexe merged commit 9929509 into main Oct 24, 2023
6 of 7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the upgrade/net7 branch October 24, 2023 20:48
Comment on lines -137 to -140
# Push Packages to our DevOps Artifacts Feed
- name: Add source
if: ${{ github.ref == 'refs/heads/main' }}
run: dotnet nuget update source LabsFeed --username dummy --password ${{ secrets.DEVOPS_PACKAGE_PUSH_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arlodotexe this is still needed in between the added PR step and the 'Push packages' still. This is why main is failing, as the source isn't updated to include the token.

michael-hawker added a commit that referenced this pull request Oct 27, 2023
Issue introduced in #503 as attempted fix/follow-on to #485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/pipeline 🔬 dev loop ➰ For issues that impact the core dev-loop of building experiments enhancement Improvement to an existing feature Uno Issues related to Uno Platform WASM Bugs related to working with WASM/Codespaces
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants