-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to .NET 7, enable WASM optimizations #485
Conversation
@Arlodotexe can you see if any of the open PRs need updating from this? Thanks! |
Wasn't sure why GitHub wasn't reporting anything, had to dig-in to the Actions page for the last build and see the 'Startup Failure' seems like one of the actions isn't on the allowlist, going to fix that. |
Going to close and re-open to kick off CI again |
@Arlodotexe CI is running again, but something up with the call to the pack script:
Maybe the sub-module isn't updated or something? Should hopefully be an easy fix of some sort either way. |
Hey guys, check out the MS video: "Upgrade your .NET projects with Visual Studio" |
# Push Packages to our DevOps Artifacts Feed | ||
- name: Add source | ||
if: ${{ github.ref == 'refs/heads/main' }} | ||
run: dotnet nuget update source LabsFeed --username dummy --password ${{ secrets.DEVOPS_PACKAGE_PUSH_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arlodotexe this is still needed in between the added PR step and the 'Push packages' still. This is why main
is failing, as the source isn't updated to include the token.
Companion PR to CommunityToolkit/Tooling-Windows-Submodule#117, which should be closed before merging this.
As noted:
This PR pulls in the .NET 7 upgrade and fixes the new warnings and errors that appeared in our codebase as a result.