-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade packages to WindowsAppSDK 1.4 #160
Comments
@LeonSpors once CommunityToolkit/Labs-Windows#485 is merged (hopefully soon), this should be easy to do. Had mentioned some possibilities, like microsoft/microsoft-ui-xaml#8810 in Discord as well [assuming that was you as well]. Are you trying to use .NET 7 as well in your project? |
Firstly, I want to apologize for the double message on both GitHub and Discord. We can verify that our project is utilizing .NET 7 along with Controls such as ItemsView. I'm pleased to report that we were able to identify the issue, and it turned out to be a cascading problem. The main issue was related to the inclusion of the CommunityToolkit.WinUI.Converters package, which wasn't explicitly added as a NuGet package but was included transitively. This caused some problems, particularly because the CommunityToolkit.Labs.WinUI.Controls.DataTable package automatically brought in CommunityToolkit.Uno. However, we cannot definitively determine whether the source of the issue was a lack of package configuration or potentially triggered by Visual Studio. We know that we are using an experimental version where complete configuration may not be feasible. The outcome of this was a multitude of ambiguities, causing the issues we encountered. However, since we've explicitly included the correct package, everything is now working smoothly with WindowsAppSDK 1.4 and .NET 7. If you have any further questions or need additional information about this, please feel free to ask. Thanks for collaboration in resolving this issue. |
Thanks for the info @LeonSpors, that's helpful! Currently, Labs is still built against earlier packages vs. the ones we shipped for 8.0 out of the @Arlodotexe we probably want another PR/issue to track updating all the dependencies of Labs components to use the shipped 8.0 packages as well, as I think we're still pointing to the pre-release ones? |
If there's a new WinUI 2 incremental update, we should bump that as well. |
Describe the bug
The
CommunityToolkit.Labs.WinUI.*
packages are built on WindowsAppSDK 1.3. If you attempt to utilize WindowsAppSDK 1.4 in conjunction with any of the labs packages, you'll encounter numerous ambiguous reference errors.Steps to reproduce
Expected behavior
It should be compatible with the most recent WinAppSDK version.
Screenshots
No response
Code Platform
Windows Build Number
Other Windows Build number
No response
App minimum and target SDK version
Other SDK version
No response
Visual Studio Version
2022
Visual Studio Build Number
No response
Device form factor
Desktop
Additional context
No response
Help us help you
Yes, I'd like to be assigned to work on this item.
The text was updated successfully, but these errors were encountered: