This repository has been archived by the owner on Nov 13, 2018. It is now read-only.
Fix TO postinstall to retry failed openssl calls #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes postinstall (generateCerts) to prompt the user if openssl fails, whether they want to retry. Ideally, we would immediately inform and retry mismatched passes, but that isn't possible while calling openssl as an external app. We would also ideally always retry, except exit if the user hit ctrl+c. But openssl doesn't return different exit codes for SIGINT versus failures. Thus, asking seems like the most reasonable option. Fixes Comcast#1063
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes postinstall (generateCerts) to prompt the user if openssl
fails, whether they want to retry.
Ideally, we would immediately inform and retry mismatched passes, but
that isn't possible while calling openssl as an external app.
We would also ideally always retry, except exit if the user hit
ctrl+c. But openssl doesn't return different exit codes for SIGINT
versus failures. Thus, asking seems like the most reasonable option.
Fixes #1063