Skip to content
This repository has been archived by the owner on Nov 13, 2018. It is now read-only.

traffic_ops postinstall process breaks on incorrect SSL pass phrase #1063

Closed
faisalusuf opened this issue Feb 17, 2016 · 0 comments
Closed
Assignees
Milestone

Comments

@faisalusuf
Copy link

Traffic_ops version: traffic_ops-1.4.0-2412.8a9a3a34.x86_64.rpm

The postinstall process get break when the SSL configuration phase starts. To reproduce the problem input a pass phrase and on reconfirm enter wrong pass phrase the process will break with errors. The expected behavior was to ask user to input pass phrase again.

Thanks

rob05c added a commit to rob05c/traffic_control that referenced this issue Mar 24, 2016
This changes postinstall (generateCerts) to prompt the user if openssl
fails, whether they want to retry.

Ideally, we would immediately inform and retry mismatched passes, but
that isn't possible while calling openssl as an external app.

We would also ideally always retry, except exit if the user hit
ctrl+c. But openssl doesn't return different exit codes for SIGINT
versus failures. Thus, asking seems like the most reasonable option.

Fixes Comcast#1063
rob05c added a commit to rob05c/traffic_control that referenced this issue Mar 25, 2016
This changes postinstall (generateCerts) to prompt the user if openssl
fails, whether they want to retry.

Ideally, we would immediately inform and retry mismatched passes, but
that isn't possible while calling openssl as an external app.

We would also ideally always retry, except exit if the user hit
ctrl+c. But openssl doesn't return different exit codes for SIGINT
versus failures. Thus, asking seems like the most reasonable option.

Fixes Comcast#1063
@elsloo elsloo added this to the 1.5.0 milestone Mar 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants