Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Add support for user scripts #69

Closed
ZeroDot1 opened this issue Jul 7, 2017 · 23 comments
Closed

Add support for user scripts #69

ZeroDot1 opened this issue Jul 7, 2017 · 23 comments
Assignees
Labels
Milestone

Comments

@ZeroDot1
Copy link
Contributor

ZeroDot1 commented Jul 7, 2017

This could be usefull to add custom css to services (e.g. https://userstyles.org/styles/142184/deezer-darkcube)

@ColinDuquesnoy ColinDuquesnoy changed the title [Wish] Add Dark CSS Style Option to Deezer PlugIn Add support for user scripts Jul 10, 2017
@ColinDuquesnoy ColinDuquesnoy self-assigned this Jul 10, 2017
@ColinDuquesnoy ColinDuquesnoy added this to the 3.1 milestone Jul 10, 2017
@ColinDuquesnoy
Copy link
Owner

ColinDuquesnoy commented Jul 10, 2017

I think we need to be more generic than add dark css to deezer. What you want actually is to be able to run custom user scripts on a specific service. I won't embed the dark css for deezer in MellowPlayer but you'll be able to define a user script that setup that style if you'd like to.

This will be in 3.1, not 3.0.

@ZeroDot1
Copy link
Contributor Author

Very good Feature, Thank you very good work :)

@ZeroDot1
Copy link
Contributor Author

Can you implement a usererscript manager to install and uninstall the user scripts?

@ColinDuquesnoy
Copy link
Owner

What do you mean? I thought you would download the script using your browser and MellowPlayer would just present a list of scripts where you add or remove scripts. Is that what you mean?

@ZeroDot1
Copy link
Contributor Author

Yes exactly.

@ZeroDot1
Copy link
Contributor Author

I use MellowPlayer every day, MellowPlayer is a great piece of software, but I miss the feature.

@ColinDuquesnoy
Copy link
Owner

Alright. I moved this issue at the top of the dev backlog.

I am using the zenhub extension to manage issues and priorities. I'd suggest you install the extension so that you can help me define priorities. We can talk about priorities on the gitter chatroom I've just created (see #119)

@ColinDuquesnoy
Copy link
Owner

screen shot 2017-09-19 at 18 45 13

ColinDuquesnoy added a commit that referenced this issue Sep 20, 2017
@ColinDuquesnoy
Copy link
Owner

@ZeroDot1 Just to let you know I've started working on this item. The class diagram is ready:

userscripts

@ZeroDot1
Copy link
Contributor Author

That looks very good, thanks for adding the feature.

@ZeroDot1
Copy link
Contributor Author

I imagined it that way, is it feasible?
usescript demo mellowplayer

@ColinDuquesnoy
Copy link
Owner

I imagined it slightly differently. The idea is to add a script icon in the services settings category (beside the switch to enable/disable a service). Clicking on the icon would bring a dialog where you can see all the user scripts attached to a particular service. It would allow you to add a script from file (it will copy the script file to the user app data dir (.local/MellowPlayer/...)) and allow remove a script from the list.

What do you think about this approach? I don't have mockups yet because I am working on the backend first.

@ZeroDot1
Copy link
Contributor Author

Yes, her idea is very good.

@ZeroDot1
Copy link
Contributor Author

When the function is ready I will do the translation into German.

ColinDuquesnoy added a commit that referenced this issue Sep 24, 2017
page is automatically reloaded when user add a user script
ColinDuquesnoy added a commit that referenced this issue Sep 24, 2017
@ColinDuquesnoy
Copy link
Owner

The feature is completed:

deezeruserscripts

deezerblack

@ZeroDot1
Copy link
Contributor Author

Thanks for adding this feature, I just finished the translation.

@ColinDuquesnoy
Copy link
Owner

@ZeroDot1 Thank you! I've integrated them.

@ZeroDot1
Copy link
Contributor Author

It works very good, thank you very much.
bildschirmfoto_2017-09-24_20-24-26

@ZeroDot1
Copy link
Contributor Author

I have tested MellowPlayer with different user scripts, it works very good. MellowPlayer is the best player for different streaming services.
Thank you!

@ZeroDot1
Copy link
Contributor Author

The Userscript Manager cannot be translated completely.
bildschirmfoto_2017-09-25_16-44-41

@ColinDuquesnoy
Copy link
Owner

The Userscript Manager cannot be translated completely.

Thank you. I added the missing strings.

@ZeroDot1
Copy link
Contributor Author

I just finished the translation.

@ColinDuquesnoy
Copy link
Owner

Thank you! I've integrated them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants