Various Config and Mongo Driver fixes #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes defaults being mixed into custom groups above the document level when doing `Group.all()` - Fixes `Config.clear_all()` with Mongo driver - Fixes `Group.set()` with Mongo driver on custom groups above the document level - Fixes `IdentifierData.custom_group_data` being set to the wrong thing in `BaseDriver.import/export_data` (although this was an inconsequential bug) Signed-off-by: Toby Harradine <[email protected]>
Signed-off-by: Toby Harradine <[email protected]>
Tobotimus
added a commit
to Tobotimus/Red-DiscordBot
that referenced
this pull request
Jun 23, 2019
It's been moved to Cog-Creators#2795 Signed-off-by: Toby Harradine <[email protected]>
Signed-off-by: Toby Harradine <[email protected]>
Tobotimus
added
QA: Passed
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group.all()Config.clear_all()with Mongo driverGroup.set()with Mongo driver on custom groups above the document levelIdentifierData.custom_group_databeing set to the wrong thing inBaseDriver.import/export_data(although this was an inconsequential bug)