[ModLog] Use custom scopes for ModLog Config #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toby Harradine <[email protected]>
Signed-off-by: Toby Harradine <[email protected]>
Tobotimus
added
Type: Enhancement
Tobotimus
requested review from
palmtree5,
tekulvw and
Twentysix26
as code owners
Signed-off-by: Toby Harradine <[email protected]>
|
PR seems to work, however I think that there is a migration failur, it cannot reference to old mod cases within the |
|
Thanks, will take a look at it later this afternoon. |
It's been moved to Cog-Creators#2795 Signed-off-by: Toby Harradine <[email protected]>
|
This PR now depends on #2795 |
Was previously doing it lexicographically, which is wrong. Signed-off-by: Toby Harradine <[email protected]>
…V3/modlog_config_redesign
Kowlin
approved these changes
Jun 24, 2019
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modlog is currently the biggest culprit for seriously large documents in the MongoDB backend, since it stores all cases as nested dicts in the guild scope. So, for example, on the Fortnite server, the guild document for @Kowlin's bot has exceeded 8MB.
This PR gives each case its own document. It also does the same for casetypes. Not only does it remove the possibility of the document exceeding the maximum size in MongoDB, it's also just more efficient for all backends.
Other changes
Config Bug
These changes highlighted a bug in Config, which I've fixed here but will probably open a new PR for: when a custom scope uses more than one primary key, but does this with a partial primary key:
conf.custom(SCOPE, primary_key_1).all(), the defaults will be mixed in with the top-level of the returned dict, even though the actual documents are nested further in.General ModLog improvements
Fixed a bunch of type-hints, and also added more support for when an object related to a case (user, moderator, channel etc.) can't be found (because it was deleted or something rather)