Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Implement --dry-run flag #1648

Merged
merged 4 commits into from
May 28, 2018
Merged

Conversation

Tobotimus
Copy link
Member

@Tobotimus Tobotimus commented May 14, 2018

Type

  • Enhancement

Description of the changes

The flag existed but didn't do anything. Now, it closes the bot's HTTPClient and exits just before it has a chance to make any connections.

Resolves #1612

@Tobotimus Tobotimus added the V3 label May 14, 2018
@Tobotimus Tobotimus added this to the Beta 15 milestone May 14, 2018
@Tobotimus Tobotimus requested a review from tekulvw as a code owner May 14, 2018 11:05
@Kowlin Kowlin merged commit 706b046 into Cog-Creators:V3/develop May 28, 2018
@Tobotimus Tobotimus deleted the V3/fix_dry_run branch June 1, 2018 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V3 Parser] --dry-run flag not handled
2 participants