Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Parser] --dry-run flag not handled #1612

Closed
laggron42 opened this issue May 8, 2018 · 3 comments · Fixed by #1648
Closed

[V3 Parser] --dry-run flag not handled #1612

laggron42 opened this issue May 8, 2018 · 3 comments · Fixed by #1648
Assignees
Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Milestone

Comments

@laggron42
Copy link
Contributor

Other bugs

What were you trying to do?

I was trying to run the bot with the --dry-run flag

What were you expecting to happen?

See the bot loading data, then stop before connecting to the gateway

  --dry-run             Makes Red quit with code 0 just before the login. This
                        is useful for testing the boot process.

What actually happened?

The bot connected to the gateway as usual, like if there weren't flags

How can we reproduce this issue?

Just run any bot with the --dry-run and see if it change something

Details

I searched for the flag in the source code to see if it was actually being used somewhere... No results.

Nice issues templates btw

@Tobotimus Tobotimus added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. V3 labels May 8, 2018
@Kowlin
Copy link
Member

Kowlin commented May 10, 2018

Thinking of removing this feature since it was a port from v2 before we started using pytests to validate a working Red instance.

@Tobotimus
Copy link
Member

I think it's fine to have this included, I don't see an exact use for it right now but you never know when it might come in handy.

@Tobotimus Tobotimus self-assigned this May 14, 2018
@Tobotimus Tobotimus added this to the Beta 15 milestone May 14, 2018
@laggron42
Copy link
Contributor Author

Thanks Toby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants