-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edit option for submission guidelines and leaderboard description #3569
Open
gautamjajoo
wants to merge
3
commits into
Cloud-CV:master
Choose a base branch
from
gautamjajoo:edit-guidelines
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -914,6 +914,40 @@ export class ChallengesettingsComponent implements OnInit, OnDestroy { | |
} | ||
} | ||
|
||
/** | ||
* Edit submission guidelines | ||
*/ | ||
editSubmissionGuidelines() { | ||
const SELF = this; | ||
SELF.apiCall = (params) => { | ||
const BODY = JSON.stringify(params); | ||
SELF.apiService | ||
.patchUrl(SELF.endpointsService.editChallengeDetailsURL(SELF.challenge.creator.id, SELF.challenge.id), BODY) | ||
.subscribe( | ||
(data) => { | ||
SELF.challenge.submission_guidelines = data.submission_guidelines; | ||
SELF.globalService.showToast('success', 'The submission guidelines are successfully updated!', 5); | ||
}, | ||
(err) => { | ||
SELF.globalService.handleApiError(err, true); | ||
SELF.globalService.showToast('error', err); | ||
}, | ||
() => {} | ||
); | ||
}; | ||
|
||
const PARAMS = { | ||
title: 'Edit Submission Guidelines', | ||
label: 'submission_guidelines', | ||
isEditorRequired: true, | ||
editorContent: this.challenge.submission_guidelines, | ||
confirm: 'Submit', | ||
deny: 'Cancel', | ||
confirmCallback: SELF.apiCall, | ||
}; | ||
SELF.globalService.showModal(PARAMS); | ||
} | ||
|
||
// Edit Leaderboard Details -> | ||
|
||
/** | ||
|
@@ -1000,6 +1034,43 @@ export class ChallengesettingsComponent implements OnInit, OnDestroy { | |
} | ||
} | ||
|
||
/** | ||
* Edit leaderboard description of the challenge | ||
*/ | ||
editLeaderboardDescription() { | ||
const SELF = this; | ||
SELF.apiCall = (params) => { | ||
const BODY = JSON.stringify(params); | ||
SELF.apiService | ||
.patchUrl(SELF.endpointsService.editChallengeDetailsURL(SELF.challenge.creator.id, SELF.challenge.id), BODY) | ||
.subscribe( | ||
(data) => { | ||
SELF.challenge.leaderboard_description = data.leaderboard_description; | ||
SELF.globalService.showToast('success', 'The leaderboard description is successfully updated!', 5); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @gautamjajoo please change the message to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
}, | ||
(err) => { | ||
SELF.globalService.handleApiError(err, true); | ||
SELF.globalService.showToast('error', err); | ||
}, | ||
() => this.logger.info('Edit Leaderboard Description') | ||
); | ||
}; | ||
|
||
/** | ||
* Parameters of the modal | ||
*/ | ||
const PARAMS = { | ||
title: 'Edit Leaderboard Description', | ||
label: 'leaderboard_description', | ||
isEditorRequired: true, | ||
editorContent: this.challenge.leaderboard_description, | ||
confirm: 'Submit', | ||
deny: 'Cancel', | ||
confirmCallback: SELF.apiCall, | ||
}; | ||
SELF.globalService.showModal(PARAMS); | ||
} | ||
|
||
// Edit Evaluation Script and Criteria -> | ||
|
||
/** | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamjajoo please change the message to
Submission guidelines updated successfully!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!