-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edit option for submission guidelines and leaderboard description #3569
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamjajoo edit options for Submission guidelines
and Leaderboard Description
should be separate. We shouldn't show it as part of the phase or phase split edit dropdown options
We would have a separate section for this right? What should be the title of that seciton? |
@gautamjajoo Instead of making a whole new section can we please keep these in a new row. Like we can keep And we can keep \cc: @Ram81 please share your thoughts on the same |
@Kajol-Kumari Actually we thought of buttons becuase initially it was done the way you have mentioned but it was felt that it is a part of phase selection that's why we changed it to buttons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamjajoo can you share the screenshot of the page and resolve merge conflicts
@Ram81 Can you please review this once more? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, rest of the PR LGTM
.subscribe( | ||
(data) => { | ||
SELF.challenge.submission_guidelines = data.submission_guidelines; | ||
SELF.globalService.showToast('success', 'The submission guidelines are successfully updated!', 5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamjajoo please change the message to Submission guidelines updated successfully!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
.subscribe( | ||
(data) => { | ||
SELF.challenge.leaderboard_description = data.leaderboard_description; | ||
SELF.globalService.showToast('success', 'The leaderboard description is successfully updated!', 5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamjajoo please change the message to Leaderboard description updated successfully!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
b2cc7fb
to
6914b70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamjajoo can resolve the merge conflcts. This PR is ready to be merged now, we can merge it once you resolve the conflicts 🙂
@Ram81 @Kajol-Kumari