Fix cleaning up broken detached part after timeout

[kssenii]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix background clean up of broken detached parts.

[kssenii]

Stress test (tsan) — Cannot start clickhouse-server

2022.09.11 20:46:49.376505 [ 513684 ] {} <Error> Application: Caught exception while loading metadata: Code: 32. DB::Exception: Attempt to read after eof: Cannot attach table `test_13`.`table` from metadata file /var/lib/clickhouse/metadata/test_13/table.sql from query ATTACH TABLE test_13.table (`x` UInt8) ENGINE = MergeTree ORDER BY x SETTINGS index_granularity = 8192. (ATTEMPT_TO_READ_AFTER_EOF), Stack trace (when copying this message, always include the lines below):

0. ./build_docker/../contrib/libcxx/include/exception:0: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x2010e4db in /usr/bin/clickhouse
1. ./build_docker/../src/Common/Exception.cpp:69: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0xb65a21c in /usr/bin/clickhouse
2. ./build_docker/../src/IO/VarInt.h:0: DB::throwReadAfterEOF() @ 0xb63d725 in /usr/bin/clickhouse
3. ./build_docker/../src/IO/ReadHelpers.h:0: void DB::readIntTextImpl<unsigned int, void, (DB::ReadIntTextCheckOverflow)0>(unsigned int&, DB::ReadBuffer&) @ 0xb80c1ab in /usr/bin/clickhouse
4. ./build_docker/../src/IO/ReadHelpers.h:0: DB::DiskObjectStorageMetadata::deserialize(DB::ReadBuffer&) @ 0x1aa66154 in /usr/bin/clickhouse
5. ./build_docker/../src/Disks/ObjectStorages/DiskObjectStorageMetadata.cpp:83: DB::DiskObjectStorageMetadata::deserializeFromString(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) @ 0x1aa67757 in /usr/bin/clickhouse
6. ./build_docker/../contrib/libcxx/include/string:1445: DB::MetadataStorageFromDisk::readMetadataUnlocked(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_lock<std::__1::shared_mutex>&) const @ 0x1aa60464 in /usr/bin/clickhouse
7. ./build_docker/../src/Disks/ObjectStorages/MetadataStorageFromDisk.cpp:0: DB::MetadataStorageFromDisk::getStorageObjects(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const @ 0x1aa60d78 in /usr/bin/clickhouse
8. ./build_docker/../contrib/libcxx/include/__memory/shared_ptr.h:816: DB::DiskObjectStorage::readFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::ReadSettings const&, std::__1::optional<unsigned long>, std::__1::optional<unsigned long>) const @ 0x1aa06867 in /usr/bin/clickhouse
9. ./build_docker/../src/Disks/DiskDecorator.cpp:0: DB::DiskDecorator::readFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::ReadSettings const&, std::__1::optional<unsigned long>, std::__1::optional<unsigned long>) const @ 0x1aa51821 in /usr/bin/clickhouse
10. ./build_docker/../src/Disks/DiskRestartProxy.cpp:0: DB::DiskRestartProxy::readFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::ReadSettings const&, std::__1::optional<unsigned long>, std::__1::optional<unsigned long>) const @ 0x1aa4d0c8 in /usr/bin/clickhouse

interesting... but not related to changes, will take a look